Problem:
I created some menu item with different language, and they link to the same node corresponding language.
Then I access the node, other menus (link same node, different language) also active.

Reproduce step:
- Create two menu item with different language.
- EN Example (link. /demo) (not have JP translation)
- JP Example (link. /jp/demo) (not have EN translation)

EN Example
JP Example

- Access /jp/demo path.

JP Frontend

Solution:

I think we should filter menu link content by current language. I created a patch for this issue.

CommentFileSizeAuthor
#11 3082857-11.patch5.18 KBburnellw_cit
#9 3082857-9.patch4.24 KBSuresh Prabhu Parkala
#7 interdiff-6_7.txt776 bytesOscaner
#7 3082857-7.patch5 KBOscaner
#6 3082857-6.patch4.98 KBOscaner
#5 menu_trail_by_path_for_multi_language.patch4.7 KBOscaner
#3 3082857-3.patch3.65 KBravi.shankar
menu_trail_based_on_current_language.patch3.8 KBOscaner
Frontend.png33.07 KBOscaner
JP Example.png16.43 KBOscaner
EN Example.png17.26 KBOscaner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Kang Miao created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs work

Patch doesn't apply anymore.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3082857-3.patch3.65 KB

Here is a re-roll of above patch.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

I don't think this behavior is consistent with core, which is why I'm unsure about adding this. Drupal core shows unrelated menu links for other languages, it just treats it as missing translation and falls back.

Oscaner’s picture

Oscaner CreditAttribution: Oscaner at CI&T commented
Parent issue: » #2910494: Performance issues when having high amount of menu items
FileSize
menu_trail_by_path_for_multi_language.patch4.7 KB

Based on this issue Performance issues when having high amount of menu items.

I did some work for menu trail by path, to support multi-language menus.

Oscaner’s picture

Oscaner CreditAttribution: Oscaner at CI&T commented
Version: 8.x-1.1 » 8.x-1.3
FileSize
3082857-6.patch4.98 KB

Based on #2910494 latest patch.

Oscaner’s picture

Oscaner CreditAttribution: Oscaner at CI&T commented
FileSize
3082857-7.patch5 KB
interdiff-6_7.txt776 bytes

Based on #2910494 latest patch.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Version: 8.x-1.3 » 2.x-dev
Status: Needs review » Needs work

Needs work after that other issue has been committed.

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
FileSize
3082857-9.patch4.24 KB

Re-rolled the patch against the latest 2.x.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

I'm assuming that this is used in combination with core patches to respect the menu link translation status because as mentioned before, core doesn't do that right now and I'm hesitant to include this before a core patch is committed.

Even then, this might not always be the expected behavior when translations are missing, should probably still return *something*

The patch also needs some coding standard improvements (indendation seems off) and $menu as a variable name is confusing, should probably be $menu_link_content.

burnellw_cit’s picture

burnellw_cit CreditAttribution: burnellw_cit commented
FileSize
3082857-11.patch5.18 KB