Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Using MediaElement 7.x-1.0 with Libraries API 7.x-2.x-dev, installed MediaElement.js in sites/all/modules/libraries/mediaelement.
When trying to configure Manage File Display on a video, I get two:
Notice: Undefined variable: link_types in mediaelement_field_formatter_settings_form() (line 204 of /../public_html/sites/all/modules/mediaelement/mediaelement.module).
Display Settings below already show MediaElement Video as a tab even though nothing is enabled. If enabling, another MediaElement Video tab shows up. I'm assuming this is where I should enable MediaElement as the player whenever I insert a video inside the editor.
I'm trying to get this working with Wysiwyg with CKEditor on my Full HTML text format. Have I configured this wrong or did the dev branch of Media break MediaElement?
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | mediaelement_undefined_variable-1170536-9.patch | 1.4 KB | jackalope |
| #3 | 0001-1170536-Undefined-variable-link_types-in-mediaelemen.patch | 1.66 KB | RandalK |
Comments
Comment #1
mcsolas CreditAttribution: mcsolas commentedRan into same error..
Comment #2
asalazar CreditAttribution: asalazar commentedI get this exact same error on a fresh in stall of MediaElement 7.x 1.0, MediaElement.js 2.1.5 and Libraries API 7.x-2.x-dev.
When attempting to adjust the Audio file type default display settings the MediaElement Video tab appears despite it not being enabled above. If you select MediaElement Audio in the MediaElement Video tab, it enables the MediaElement Audio above and creates a second tab.
Furthermore, after you save a configuration with MediaElement Audio enabled, changes you make no longer appear to be saved.
Comment #3
RandalK CreditAttribution: RandalK commentedHeres a simple little patch
Going by #948584: Wrong implementations of hook_field_formatter_settings_form() renaming form to element fixes duplicates on settings form.
Also removes #options key from the width form element fixing the undefined var error.
Comment #4
brianV CreditAttribution: brianV commented+1 for this patch. Technically, it's fixing two separate issue in one patch, but they both need to be fixed anyways.
Without this patch, you can't save changes to file styles, which breaks the Media module compatibility.
Comment #5
Dave ReidYep, confirmed this is a good fix.
Comment #6
mfer CreditAttribution: mfer commentedFixed in the upcoming 2.x branch. http://drupalcode.org/project/mediaelement.git/commit/462c7f76033725b56d...
Comment #8
ZuluWarrior CreditAttribution: ZuluWarrior commentedSub,
Can we see the above fix rolled into the 7.x-1.1 release please?
Twice now this patch has caught me out on an install! I can confirm it works with latest stable's of media related dependent modules...
Be great if this could be included, would make it much easier for folks who come along and plug it straight into media/vanilla drupal...
Comment #9
jackalope CreditAttribution: jackalope commentedEchoing ZuluWarrior – would be great to get this fix rolled into the 7.x-1.2 release!
I've also recreated the patch using the recommended git method, in case that's helpful to anyone else.
Comment #10
bryancasler CreditAttribution: bryancasler commentedThere is a duplicate issue que posts here #1170842: Undefined variable: link_types in mediaelement_field_formatter_settings_form().
I've marked it as a duplicate of this one.
Comment #11
bryancasler CreditAttribution: bryancasler commentedI can also confirm the patch in #9 works.
Comment #12
zambrey CreditAttribution: zambrey commented+1
Comment #13
robbielink CreditAttribution: robbielink commented#9 worked for me - thanks!
Comment #14
Dave ReidThis has now been fixed in the 7.x-1.x branch and a new release is coming soon.