Problem/Motivation

I use this module with inline_entity_form and entity_browser.
If I select images once and then delete them the field is empty but I get a Constraint Message (At least one slideshow item must exist.)
Imho we should not put this constraint if the field is not required it should be allowed to be empty.

Proposed resolution

Improve if statement in ItemsCountConstraintValidator

CommentFileSizeAuthor
#8 3015310_allow_field_to_be_empty_4.patch2.06 KBAntoniya
#7 3015310_allow_field_to_be_empty_3.patch2 KBAntoniya
#2 3015310_allow_field_to_be_empty_2.patch708 bytesDiDebru
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Insasse created an issue. See original summary.

DiDebru’s picture

DiDebru
Primary language German
CreditAttribution: DiDebru at UEBERBIT GmbH commented
FileSize
3015310_allow_field_to_be_empty_2.patch708 bytes
RumenDamyanov’s picture

RumenDamyanov
Primary language Bulgarian
Location Bulgaria
CreditAttribution: RumenDamyanov as a volunteer commented

Thank you for the patch. I tested it and it works as intended.

Shenron_segamag’s picture

Shenron_segamag CreditAttribution: Shenron_segamag commented

I can also confirm that the patch works.

Antoniya’s picture

Antoniya CreditAttribution: Antoniya commented
Version: 8.x-2.0-alpha1 » 8.x-2.x-dev
Status: Active » Reviewed & tested by the community

Tested this against core 9.1.7 and media_entity_slideshow 2.4. I'd say it's ready to be committed.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3015310_allow_field_to_be_empty_2.patch, failed testing. View results

Antoniya’s picture

Antoniya CreditAttribution: Antoniya commented
Status: Needs work » Needs review
FileSize
3015310_allow_field_to_be_empty_3.patch2 KB

Updated the failing test.

Antoniya’s picture

Antoniya CreditAttribution: Antoniya commented
Status: Needs review » Reviewed & tested by the community
FileSize
3015310_allow_field_to_be_empty_4.patch2.06 KB

Minor coding standard issue. Triggering the test bot again.