Problem/Motivation

Info file lacks support for D10.

Default config file contains duplicate lines and unquoted special characters (%).

Functions drupal_get_path() and drupal_get_filename() have been deprecated in favor of extension listing services: https://www.drupal.org/node/2940438

Functions file_create_url() and file_url_transform_relative() are deprecated: https://www.drupal.org/node/2940031

Steps to reproduce

Try to install the theme on a D10 site

Proposed resolution

Add support for D10 in info file.
Remove duplicate line and quote special chars in config file.
Use the extension.list.theme and file_url_generator services instead of the deprecated functions.

Remaining tasks

Review the merge request.
Create a D9 / D10 compatible release.

CommentFileSizeAuthor
#3 mayo_d10-3334500-3.patch13.2 KBreszli
#2 mayo_d10-3334500-2.patch9.73 KBreszli

Issue fork mayo-3334500

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

reszli created an issue. See original summary.

reszli’s picture

reszli
he/him
Primary language Hungarian
Location Târgu Mureș
CreditAttribution: reszli at Dropsolid commented
Issue summary: View changes
Status: Active » Needs review
FileSize
mayo_d10-3334500-2.patch9.73 KB

Created a patch to get rid of the deprecated function.

Note, you also need the changes from https://www.drupal.org/project/mayo/issues/3148030#comment-14187595 first.

reszli’s picture

reszli
he/him
Primary language Hungarian
Location Târgu Mureș
CreditAttribution: reszli at Dropsolid commented
FileSize
mayo_d10-3334500-3.patch13.2 KB

Updated issue description with more problems.
Updated patch to cover all reported problems.

reszli’s picture

reszli
he/him
Primary language Hungarian
Location Târgu Mureș
CreditAttribution: reszli at Dropsolid commented
Issue summary: View changes
reszli’s picture

reszli
he/him
Primary language Hungarian
Location Târgu Mureș
CreditAttribution: reszli at Dropsolid commented
reszli’s picture

reszli
he/him
Primary language Hungarian
Location Târgu Mureș
CreditAttribution: reszli at Dropsolid commented
Issue summary: View changes

Darren Oh made their first commit to this issue’s fork.

Darren Oh opened merge request !2

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh as a volunteer commented
Issue summary: View changes
Related issues: +#3148030: Automated Drupal 9 compatibility fixes
Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh as a volunteer commented
Issue summary: View changes

ogwin changed the visibility of the branch 3334500-drupal-10-compatibility to hidden.

ogwin changed the visibility of the branch 3334500-drupal-10-compatibility to hidden.

Darren Oh changed the visibility of the branch 3334500-drupal-10-compatibility to active.