Notice: Array to string conversion in material_admin_preprocess_input() (line 81 of themes/contrib/material_admin/inc/preprocess.inc).

CommentFileSizeAuthor
#15 material_admin-v2-array_to_string_notice-2989199-15.patch959 bytesocastle
#9 material_admin-array_to_string_notice-2989199-9.patch959 bytesmvonfrie
#7 implode-argument-must-be-array-2989199-7.patch836 bytesxpersonas
#5 material_admin-array_to_string_notice-2989199-5-D8.patch831 bytesreszli
#3 warning-msg.txt7.74 KBsergei_semipiadniy
#3 material_admin-array_to_string_notice-2989199-2-D8.patch778 bytessergei_semipiadniy
array-to-string-notice-fix-1.patch657 bytesxpersonas

Comments

xpersonas created an issue. See original summary.

  • xpersonas authored cdd7b52 on 8.x-1.x 
    Issue #2989199 by xpersonas: Fixing Array to String Notice for PHP 7.x
sergei_semipiadniy’s picture

sergei_semipiadniy commented
Version: 8.x-1.0-alpha6 » 8.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new material_admin-array_to_string_notice-2989199-2-D8.patch778 bytes
new warning-msg.txt7.74 KB

Hi,

@xpersonas, I installed fresh drupal 8.5.6 and faced with a warning, probably, that has been appeared after this fix.

File with dump of a warning is enclosed, as well as a fresh patch.

Regards

jwjoshuawalker’s picture

jwjoshuawalker commented

Same error here. The patch fixes it, but I feel like we could do this more cleanly.

reszli’s picture

reszli
he/him
Primary language Hungarian
Location Târgu Mureș
commented
StatusFileSize
new material_admin-array_to_string_notice-2989199-5-D8.patch831 bytes

slightly modified patch to remove all errors
I agree that this is probably not the best way, but who's in a hurry...

mariagwyn’s picture

mariagwyn commented

I can confirm that the patch silences the error.

xpersonas’s picture

xpersonas commented
StatusFileSize
new implode-argument-must-be-array-2989199-7.patch836 bytes

I'm debating if this should be a new issue, but it involves the exact same piece of code so i'm putting it here. I'm getting a notice about the implode function in this check....

Warning: implode(): Argument must be an array

I have a new patch that breaks the argument into two lines, checking that it's an array first. If you guys have a better way to handle, let me know. But this is working for me at the moment.

mvonfrie’s picture

mvonfrie commented

I have the exact same issue with Drupal 8.6.10 now and figured out that $variables['attributes']['placeholder'] can be a string instead of an array, either empty or with a placeholder value (e. g. for a Drupal Commerce price field the default placeholder is 9,99 and "9.99" == $variables['attributes']['placeholder'].

According to https://secure.php.net/manual/en/function.implode.php the implode function has two signatures:

implode(string = "", array)
implode(array)

If $variables['attributes']['placeholder'] is expected to be an array as in all previous patches but actually is a string, none of the implode function matches because the string is optional and the array is required.

mvonfrie’s picture

mvonfrie commented
StatusFileSize
new material_admin-array_to_string_notice-2989199-9.patch959 bytes

Here is a new patch with different checks whether $variables['attributes']['placeholder'] is a string or an array.

bleen’s picture

bleen commented
Status: Needs review » Reviewed & tested by the community

Just tested with alpha7 and this worked perfect ... based on the comments in #8 this fix makes sense.

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented

Another confirmation that the patch fixes the issue.

thejimbirch’s picture

thejimbirch commented

That patch in #9 applies to alpha7 and fixes the warnings.

To Verify:
Visit /admin/reports/updates
Visit /admin/reports/dblog and verify the PHP Warning did not post.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch everyone! This should be merged now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ocastle’s picture

ocastle commented
Version: 8.x-1.x-dev » 2.x-dev
StatusFileSize
new material_admin-v2-array_to_string_notice-2989199-15.patch959 bytes

This change has been lost in 2.x

Attaching Patch.

thejimbirch’s picture

thejimbirch commented

You may want to open a new issue @ocastle. Only maintainers can reopen closed issues so they may not see this.

ocastle’s picture

ocastle commented

Thanks @thejimbirch - Done

https://www.drupal.org/project/material_admin/issues/3197375