Fixing Array to String Notice for PHP 7 on 2.X [#3197375]

Notice: Array to string conversion in material_admin_preprocess_input() (line 81 of themes/contrib/material_admin/inc/preprocess.inc).

Fixed in 8.x-1.x but needs to be ported to 2.x

Attached patch.

Comment	File	Size	Author
#5	3197375-array-to-string-notice.patch	961 bytes	grigoriunicolae
#4	3197375-array-to-string-notice.patch	899 bytes	grigoriunicolae
#3	3197375-array-to-string-notice.patch	830 bytes	grigoriunicolae
	material_admin-v2-array_to_string_notice.patch	959 bytes	ocastle

Comments

Comment #1

8 February 2021 at 21:42

ocastle created an issue. See original summary.

Comment #2

osman

Copenhagen

commented 27 March 2021 at 00:11

The patch works.

But may I ask why not simplify like this?

diff --git a/inc/preprocess.inc b/inc/preprocess.inc
index 6e92b9b..3667fa3 100644
--- a/inc/preprocess.inc
+++ b/inc/preprocess.inc
@@ -84,7 +84,7 @@ function material_admin_preprocess_menu_local_task(&$variables) {
  */
 function material_admin_preprocess_input(&$variables) {
   $element = $variables['element'];
-  if (isset($variables['attributes']['placeholder']) && empty(implode($variables['attributes']['placeholder']))) {
+  if (empty($variables['attributes']['placeholder'])) {
     unset($variables['attributes']['placeholder']);
   }
   $variables['children'] = $element['#children'];