Problem/Motivation

Use of static methods

Proposed resolution

Dependency injection on LinkCheckerAdminSettingsForm

CommentFileSizeAuthor
#4 linkchecker-Dependency_injection_on_LinkCheckerAdminSettingsForm-3059660-2-D8.patch5.35 KBthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review

Follow a patch with dependency injection.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Needs work

Your patch is missing...

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
FileSize
linkchecker-Dependency_injection_on_LinkCheckerAdminSettingsForm-3059660-2-D8.patch5.35 KB

😅
Now!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review

  • hass committed 0688517 on 8.x-1.x authored by thalles 
    Issue #3059660 by thalles: Dependency injection on...
hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.