Error: Call to a member function isInternal() on null (RelationshipNormalizerValue.php) [#2946969]

Hello, as it was mentioned here https://www.drupal.org/project/jsonapi_extras/issues/2946790 I have problem with version 8.x-1.10 and extras dev-1.x c2d0f5368a8a19b5aa4f525977ca62d62d7362d6 with patch https://www.drupal.org/files/issues/2946790-2.patch (it doesnt work without patch).. now im getting:

[22-Feb-2018 16:31:48] WARNING: [pool www] child 6 said into stderr: "NOTICE: PHP message: Error: Call to a member function isInternal() on null in /var/www/html/docroot/modules/contrib/jsonapi/src/Normalizer/Value/RelationshipNormalizerValue.php on line 120 #0 /var/www/html/docroot/modules/contrib/jsonapi/src/Normalizer/Value/RelationshipNormalizerValue.php(98): Drupal\jsonapi\Normalizer\Value\RelationshipNormalizerValue::hasNonInternalResourceType(Array)"
[22-Feb-2018 16:31:48] WARNING: [pool www] child 6 said into stderr: "#1 /var/www/html/docroot/modules/contrib/jsonapi/src/Normalizer/Value/RelationshipNormalizerValue.php(68): Drupal\jsonapi\Normalizer\Value\RelationshipNormalizerValue->getLinks('parent')"
[22-Feb-2018 16:31:48] WARNING: [pool www] child 6 said into stderr: "#2 /var/www/html/docroot/modules/contrib/jsonapi/src/Normalizer/Value/EntityNormalizerValue.php(109): Drupal\jsonapi\Normalizer\Value\RelationshipNormalizerValue->rasterizeValue()"
[22-Feb-2018 16:31:48] WARNING: [pool www] child 6 said into stderr: "#3 /var/www/html/docroot/modules/contrib/jsonapi/src/Normalizer/Value/JsonApiDocumentTopLevelNormalizerValue.php(127): Drupal\jsonapi\Normalizer\Value\EntityNormalizerValue->rasterizeValue()"
[22-Feb-2018 16:31:48] WARNING: [pool www] child 6 said into stderr: "#4 /var/www/html/docroot/modules/contrib/jsonapi/src/Normalizer/Value/J..."

I've found that when i try to access my resource without any include it works, when i try to add include for user (uid) or for example paragraphs which i have in this entity im getting it still works, when I try to add include to categories (reference to taxonomy term) it will fail with error above.

Comment	File	Size	Author
#14	2946969--isInternal-on-null--14.patch	11.19 KB	e0ipso
#14	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply
#14	2946969--interdiff--13-14.patch	1.21 KB	e0ipso
#14	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply
#13	2946969--isInternal-on-null--13.patch	12.4 KB	e0ipso
#13	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply
#13	2946969--interdiff--12-13.txt	7.46 KB	e0ipso
#12	2946969-12.patch	5.24 KB	gabesullice
#12	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply
#8	2946969--isInternal-on-null--8.patch	1.21 KB	e0ipso
#8	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 2 pass
#3	isinternal_on_null-2946969-3.patch	855 bytes	mkolar
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 February 2018 at 16:47

mkolar created an issue. See original summary.

Comment #2

mkolar CreditAttribution: mkolar at Ciklum Western Europe for BurdaForward commented 22 February 2018 at 16:48

Title:

Error: Call to a member function isInternal()

» Error: Call to a member function isInternal() on null (RelationshipNormalizerValue.php)

Comment #3

mkolar CreditAttribution: mkolar at Ciklum Western Europe for BurdaForward commented 22 February 2018 at 16:59

File	Size
isinternal_on_null-2946969-3.patch	855 bytes

This fixes an issue, but dont know why there is NULL value in the $resource_types array.

Comment #4

gabesullice

English

CreditAttribution: gabesullice at Acquia commented 22 February 2018 at 17:39

Project:	JSON:API	» JSON:API Extras
Version:	8.x-1.10	» 8.x-1.x-dev
Status:	Active	» Needs work

@mkolar, This issue is still in JSON API Extras I believe. It is currently "filtering out" disabled resources. But it should actually be setting them as "internal" per the new strategy in JSON API. It hasn't yet adopted that strategy.

Instead of the ConfigurableResourceTypeRepository just stripping out disabled resources, it should be setting the $internal property on the ResourceType by passing TRUE to the ConfigurableResourceType constructor.

I may be able to work on this soon, but if someone else can do it, that would make it happen much faster! I'm happy to provide reviews/guidance here.

Comment #5

mkolar CreditAttribution: mkolar at Ciklum Western Europe for BurdaForward commented 22 February 2018 at 17:48

1 file was hidden/shown/deleted

File	Size
isinternal_on_null-2946969-3.patch	855 bytes

Comment #6

mkolar CreditAttribution: mkolar at Ciklum Western Europe for BurdaForward commented 22 February 2018 at 18:17

@gabesullice but I have all resources I'm including enabled, I've just checked.. I have disabled taxonomy_vocabulary--taxonomy_vocabulary and also some other taxonomy_term resources but categories resource is enabled (and overridden)..

Comment #7

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 22 February 2018 at 23:02

@mkolar can you share your request? I can't seem to reproduce this.

Comment #8

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 22 February 2018 at 23:37

Status:

Needs work

» Needs review

File	Size
2946969--isInternal-on-null--8.patch	1.21 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 2 pass

I think this may work. I was not able to reproduce this, but I have the feeling it's because of this.

@mkolar can you try this patch and see if it works?

Comment #9

bmx269 CreditAttribution: bmx269 as a volunteer commented 23 February 2018 at 00:39

The patch in #8 fixed the issue for me.

Comment #10

mkolar CreditAttribution: mkolar at Ciklum Western Europe for BurdaForward commented 23 February 2018 at 08:17

Status:

Needs review

» Reviewed & tested by the community

I can also confirm that #8 works.. thanks @e0ipso and @gabesullice...

Comment #11

gabesullice

English

CreditAttribution: gabesullice at Acquia commented 23 February 2018 at 09:52

Status:

Reviewed & tested by the community

» Needs work

@e0ipso, I can see why #8 fixed the problem. I think it would be okay to commit this immediately to "unbreak" most people's sites. However, I think you'll definitely need a follow-up.

All the relatable resource type stuff in JSON API operates on the principle that every resource type is present, but may be marked internal. If JSON API Extras does any filtering it's probably going to subtly break something else. I actually tried to build the internal thing in a way that would actually simplify this module :) just by marking a ResourceType as internal, JSON API itself will do the necessary filtering on its own.

Comment #12

gabesullice

English

CreditAttribution: gabesullice at Acquia commented 23 February 2018 at 10:48

Status:

Needs work

» Needs review

File	Size
2946969-12.patch	5.24 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply

Behold, simplicity.

Comment #13

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 23 February 2018 at 12:03

File	Size
2946969--interdiff--12-13.txt	7.46 KB
2946969--isInternal-on-null--13.patch	12.4 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply

2 files were hidden/shown/deleted

File	Size
2946969--isInternal-on-null--8.patch	1.21 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 2 pass
2946969-12.patch	5.24 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply

Comment #14

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 23 February 2018 at 12:08

File	Size
2946969--interdiff--13-14.patch	1.21 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply
2946969--isInternal-on-null--14.patch	11.19 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply

2 files were hidden/shown/deleted

File	Size
2946969--interdiff--12-13.txt	7.46 KB
2946969--isInternal-on-null--13.patch	12.4 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.5 Patch Failed to Apply

I need to remove #8 from the patch.

Edit: interdiff was not meant to be a patch 😟

Comment #15

23 February 2018 at 12:09

e0ipso committed edecde6 on 8.x-1.x

Issue #2946969 by e0ipso, mkolar, gabesullice, bmx269: Error: Call to a...

Comment #16

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 23 February 2018 at 12:10

Status:

Needs review

» Fixed

I merged this because this also fixes the branch tests.

Comment #17

vtcore CreditAttribution: vtcore commented 23 February 2018 at 15:52

Sorry to reopen this, but after this commit the module cannot be enabled.

The commit adds a version requirement jsonapi:jsonapi (>=8.x-1.10) but jsonapi does not have a version specified in its jsonapi.info.yml.

Comment #18

23 February 2018 at 16:05

e0ipso committed 46f2ded on 8.x-1.x

Issue #2946969 by e0ipso, vtcore: Require JSON API 1.10 or later

Comment #19

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 23 February 2018 at 16:05

Thanks for noting that. The version is added by the drupal.org packager.

However, according to: https://www.drupal.org/node/2000204

dependencies - A list of other modules your module depends on. Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name. Dependencies can also include version restrictions, for examplewebform:webform (>=8.x-5.x). Note that if your module has dependencies on other contributed modules or libraries, these should be declared in the module's composer.json file.

Hence dropping the version range here and adding a composer.json file.

See commit above.