Problem/Motivation

PHPStorm is complaining about needed parameter in getAnalyzerResult(). Seems like a bug in ProcessorResultInterface.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 remove_topic_from-2817027-8.patch1.33 KBtoncic
#6 interdiff-2817027-4-7.txt1.63 KBtoncic
#6 remove_topic_from-2817027-6.patch1.33 KBtoncic
#4 interdiff-2817027-2-4.txt906 bytestoncic
#4 remove_topic_from-2817027-4.patch1.86 KBtoncic
#2 remove_topic_from-2817027-2.patch1.49 KBtoncic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

toncic92 created an issue. See original summary.

toncic’s picture

toncic CreditAttribution: toncic at MD Systems GmbH commented
Status: Active » Needs review
FileSize
remove_topic_from-2817027-2.patch1.49 KB

Refactor getAnalyzerResult function.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs review » Needs work

I meant to fix the method signature and its documentation: ProcessorResultInterface::getAnalyzerResult.

toncic’s picture

toncic CreditAttribution: toncic at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
remove_topic_from-2817027-4.patch1.86 KB
interdiff-2817027-2-4.txt906 bytes

Yes of course.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/src/ProcessorResultInterface.php
@@ -48,16 +48,12 @@ interface ProcessorResultInterface {
-  public function getAnalyzerResult($topic);
+  public function getAnalyzerResult();

As discussed, we should just synchronize the method signatures (base implementation and the interface representation).

You did a good part of #2770567: Remove ability to extend results by "topic" now that there are contexts. So you can upload a patch there.

Edit: Please update the issue title to describes to needed change.

toncic’s picture

toncic CreditAttribution: toncic at MD Systems GmbH commented
Title: Remove $topic from getAnalyzerResult call » Add default parameter in interface
Status: Needs work » Needs review
FileSize
remove_topic_from-2817027-6.patch1.33 KB
interdiff-2817027-4-7.txt1.63 KB

Added default parameter in getAnalyzerResult in ProcessorResultInterface.

Status: Needs review » Needs work

The last submitted patch, 6: remove_topic_from-2817027-6.patch, failed testing.

toncic’s picture

toncic CreditAttribution: toncic at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
remove_topic_from-2817027-8.patch1.33 KB

Re based patch.

  • mbovan committed 5732254 on 8.x-1.x authored by toncic92 
    Issue #2817027 by toncic92: Add default parameter in interface
mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs review » Fixed

Fixed. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.