Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Mailhandler uses default analyzer result for its analyzer collaboration by directly specifying the object and the topic.
Proposed resolution
Since DefaultAnalyzerResult
is in Inmail core, we should remove unnecessary part: DefaultAnalyzerResult::TOPIC
from our calls $processor_result->getAnalyzerResult()
.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff-2816131-3-7.txt | 4.26 KB | toncic |
#7 | remove_default_analyzer-2816131-7.patch | 12.37 KB | toncic |
#5 | remove_default_analyzer-2816131-3.patch | 10.7 KB | toncic |
#2 | remove_default_analyzer-2816131-2.patch | 10.7 KB | toncic |
Comments
Comment #2
toncic CreditAttribution: toncic at MD Systems GmbH commentedRemove DefaultAnalyzerResult from call getAnalyzerResult(). Test is failing becaus HEAD fails.
Comment #5
toncic CreditAttribution: toncic at MD Systems GmbH commentedTrying again the same patch when HEAD is fixed.
Comment #6
mbovan CreditAttribution: mbovan at MD Systems GmbH commentedPHPStorm is complaining about needed parameter in
getAnalyzerResult()
. Seems like a bug inProcessorResultInterface
. Could you open an issue in Inmail for that.Also, we have many unnecessary calls to
ensureAnalyzerResult()
(after the related Inmail change was introduced). We can remove them as well.Comment #7
toncic CreditAttribution: toncic at MD Systems GmbH commentedRemoved ensureAnalyzerResult.
Created issue in inmail.
Comment #9
mbovan CreditAttribution: mbovan at MD Systems GmbH commentedVery nice! Thank you!