Problem/Motivation

Mailhandler uses default analyzer result for its analyzer collaboration by directly specifying the object and the topic.

Proposed resolution

Since DefaultAnalyzerResult is in Inmail core, we should remove unnecessary part: DefaultAnalyzerResult::TOPIC from our calls $processor_result->getAnalyzerResult().

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 interdiff-2816131-3-7.txt4.26 KBtoncic
#7 remove_default_analyzer-2816131-7.patch12.37 KBtoncic
#5 remove_default_analyzer-2816131-3.patch10.7 KBtoncic
#2 remove_default_analyzer-2816131-2.patch10.7 KBtoncic

Comments

mbovan created an issue. See original summary.

toncic’s picture

toncic commented
Assigned: Unassigned » toncic
Status: Active » Needs review
StatusFileSize
new remove_default_analyzer-2816131-2.patch10.7 KB

Remove DefaultAnalyzerResult from call getAnalyzerResult(). Test is failing becaus HEAD fails.

Status: Needs review » Needs work

The last submitted patch, 2: remove_default_analyzer-2816131-2.patch, failed testing.

The last submitted patch, 2: remove_default_analyzer-2816131-2.patch, failed testing.

toncic’s picture

toncic commented
Status: Needs work » Needs review
StatusFileSize
new remove_default_analyzer-2816131-3.patch10.7 KB

Trying again the same patch when HEAD is fixed.

mbovan’s picture

mbovan commented
Status: Needs review » Needs work

PHPStorm is complaining about needed parameter in getAnalyzerResult(). Seems like a bug in ProcessorResultInterface. Could you open an issue in Inmail for that.

Also, we have many unnecessary calls to ensureAnalyzerResult() (after the related Inmail change was introduced). We can remove them as well.

toncic’s picture

toncic commented
Status: Needs work » Needs review
Related issues: +#2817027: Add default parameter in interface
StatusFileSize
new remove_default_analyzer-2816131-7.patch12.37 KB
new interdiff-2816131-3-7.txt4.26 KB

Removed ensureAnalyzerResult.
Created issue in inmail.

  • mbovan committed 4efdf41 on 8.x-1.x authored by toncic92 
    Issue #2816131 by toncic92: Remove default analyzer topic call
mbovan’s picture

mbovan commented
Status: Needs review » Fixed

Very nice! Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.