Problem/Motivation

Tests have been failing since the patch from #3112427: \Drupal calls should be avoided in classes, use dependency injection instead in src/Plugin/Field/FieldWidget/InlineEntityFormBase.php got committed, we need to fix those.

CommentFileSizeAuthor
#8 reroll.patch5.92 KBelber
#2 3307144-2.patch6.56 KBjsacksick
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

Status: Active » Needs review
StatusFileSize
new6.56 KB

Blind attempt at fixing tests.

podarok’s picture

Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs review » Needs work
git apply 3307144-2.patch 
error: patch failed: src/Plugin/Field/FieldWidget/InlineEntityFormBase.php:2
error: src/Plugin/Field/FieldWidget/InlineEntityFormBase.php: patch does not apply
error: patch failed: src/Plugin/Field/FieldWidget/InlineEntityFormComplex.php:2
error: src/Plugin/Field/FieldWidget/InlineEntityFormComplex.php: patch does not apply

needs reroll

shivam_tiwari made their first commit to this issue’s fork.

shivam_tiwari’s picture

Assigned: Unassigned » shivam_tiwari
shivam_tiwari’s picture

Assigned: shivam_tiwari » Unassigned
elber’s picture

Assigned: Unassigned » elber

I will work on it

elber’s picture

Assigned: elber » Unassigned
Status: Needs work » Needs review
StatusFileSize
new5.92 KB

I added a reroll please revise.

podarok’s picture

Status: Needs review » Needs work
podarok’s picture

dcam’s picture

Status: Needs work » Closed (outdated)

The 2.x branch has been abandoned. Please upgrade to 3.x or downgrade to 1.x.