Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

StatusFileSize
new3.38 KB

Kindly review a patch.

hardik_patel_12’s picture

Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3112427-2.patch, failed testing. View results

swatichouhan012’s picture

Assigned: Unassigned » swatichouhan012
Issue tags: +VbContribution2020
swatichouhan012’s picture

Assigned: swatichouhan012 » Unassigned
damienmckenna’s picture

Assigned: Unassigned » damienmckenna
damienmckenna’s picture

Assigned: damienmckenna » Unassigned
Status: Needs work » Needs review
StatusFileSize
new4.58 KB
new6.28 KB

A work in progress, but running it locally it isn't happen with $container->get('content_translation.manager').

Status: Needs review » Needs work

The last submitted patch, 8: inline_entity_form-n3112427-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

saphemmy’s picture

Assigned: Unassigned » saphemmy
saphemmy’s picture

Assigned: saphemmy » Unassigned
Status: Needs work » Needs review

I tried working on it with the following steps:

  1. I navigated to inline_enetity_form Version Control
  2. Used git command:
    git clone --branch '8.x-1.x' https://git.drupalcode.org/project/inline_entity_form.git
    cd inline_entity_form
  3. Ran automated tests locally, which all passed before trying to work on it
  4. Located the file according to the scope of the issue i.e InlineEntityFormBase.php. Saw the dependency Injection has been addressed

I will suggest a second eye before this issue is changed to fixed/RTBC/Works as designed

Johnny Santos’s picture

Status: Needs review » Reviewed & tested by the community

I just checked without the patch and the phpcs indeed points to whats demanded on the issue, in the file.
Applied the patch in comment #8 and its gone.

Thats for me a RTBC, since the scope is fixed.

  • ram4nd committed 0b96242 on 8.x-1.x
    Issue #3112427 by DamienMcKenna, Johnny Santos: \Drupal calls should be...
ram4nd’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -VbContribution2020
jsacksick’s picture

I'm not sure why this got committed despite the failing tests?

  • ram4nd committed 645ac92 on 8.x-1.x
    Revert Issue #3112427 by DamienMcKenna, Johnny Santos: \Drupal calls...
ram4nd’s picture

Status: Fixed » Needs work

Reverted the patch. If you wonder why it got committed, it's due to the RTBC. But yes I agree, I shouldn't have committed it with failing tests.

jsacksick’s picture

fwiw, test failures were addresses as part of #3307144: Tests are failing...

lucienchalom’s picture

StatusFileSize
new3.54 KB

Using the patch on #2 and the patch on #3307144-2: Tests are failing, almost all the tests are running again.
TBH, I think the problem is bigger than this one test failing because is the test to check all the translations, and the DI is of 'content_translation.manager' but I cannot find any mistake on the DI.

vishaljd made their first commit to this issue’s fork.

vishaljd’s picture

Assigned: Unassigned » vishaljd

vishaljd’s picture

Assigned: vishaljd » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 19: 3112427-19.patch, failed testing. View results

podarok’s picture

Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.