| Comment | File | Size | Author |
|---|---|---|---|
| #19 | 3112427-19.patch | 3.54 KB | lucienchalom |
| #8 | inline_entity_form-n3112427-8.patch | 6.28 KB | damienmckenna |
| #8 | inline_entity_form-n3112427-8.interdiff.txt | 4.58 KB | damienmckenna |
| #2 | 3112427-2.patch | 3.38 KB | hardik_patel_12 |
Issue fork inline_entity_form-3112427
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3112427-drupal-calls-should
compare
- coding_standard
changes, plain diff MR !66
Comments
Comment #2
hardik_patel_12 commentedKindly review a patch.
Comment #3
hardik_patel_12 commentedComment #5
swatichouhan012 commentedComment #6
swatichouhan012 commentedComment #7
damienmckennaComment #8
damienmckennaA work in progress, but running it locally it isn't happen with $container->get('content_translation.manager').
Comment #10
saphemmy commentedComment #11
saphemmy commentedI tried working on it with the following steps:
I will suggest a second eye before this issue is changed to fixed/RTBC/Works as designed
Comment #12
Johnny Santos commentedI just checked without the patch and the phpcs indeed points to whats demanded on the issue, in the file.
Applied the patch in comment #8 and its gone.
Thats for me a RTBC, since the scope is fixed.
Comment #14
ram4nd commentedComment #15
jsacksick commentedI'm not sure why this got committed despite the failing tests?
Comment #17
ram4nd commentedReverted the patch. If you wonder why it got committed, it's due to the RTBC. But yes I agree, I shouldn't have committed it with failing tests.
Comment #18
jsacksick commentedfwiw, test failures were addresses as part of #3307144: Tests are failing...
Comment #19
lucienchalom commentedUsing the patch on #2 and the patch on #3307144-2: Tests are failing, almost all the tests are running again.
TBH, I think the problem is bigger than this one test failing because is the test to check all the translations, and the DI is of 'content_translation.manager' but I cannot find any mistake on the DI.
Comment #21
vishaljd commentedComment #23
vishaljd commentedComment #26
podarok