Allow to hide the Edit button in Complex widget

I think this feature request definitely makes sense. I tested it and it does the job. Having some basic test just to confirm the button is displayed or not is probably appreciable given the numerous tests which already exist in the module.

Test needed

Thank you for the patch!
Tested it and it's working well

@RajabNatshah: If you set RTBC, provide a reasoning why you do so. Especially why you ignore the reasoning from #4.

So in the end: #4 i right, this needs test coverage.

Thanks, Merlin for having time to follow up on this issue <3

Agrees with you. I rushed into changing the status as:

We have been using the patch in Varbase with number of projects for long time

Related issues:

#3155922: Change default entityqueue form display for the [Media Hero Slider] entity queue

#3156138: Add patch for [Inline Entity Form] module to allow to hide the Edit button in Complex widget

I hoped that it could be better to have it in the latest release or the next one.

#3209310: Update Inline Entity Form module from 1.0-rc8 to 1.0-rc9

The test case could be a complex one too.
like the entityqueue case, or a product, paragraph, or other ways.

Do you have any proposed automated testing for this complex change?
or a custom coded entity with a custom inline entity form too.

My only hope to have this feature in the next release.

OK let's see how we can get this in. But i'm not sure i understand the question.

I agree with #3:
> Having some basic test just to confirm the button is displayed or not is probably appreciable given the numerous tests which already exist in the module.

So this should be super simple.

For multiple bundles, could we have a setting per each one?
Let's say I want users to edit Articles but not Basic Pages direcltly in the widget.

Tested the 3143422-10.patch under PHP 8 after the new 1.0-rc10
It's working well.
+ Basic automated testing.

Thanks for pushing this forward! See review.

Also, if that is fixed, please follow the tradition to add a "test-only-shoud-fail" patch or MR, to prove the test tests what it claims to test.

For the to-commit solution, i'd prefer adding to the MR.

Agrees with Merlin :)

Thanks for having extra time to follow up on this issue.

Maybe I'm rushing to have this feature in the module. As it is been tested for almost 1 year in many projects.

Following and moving to the MR workflow for sure.

Noted;
Not only to have a functional/unit test pass with green.
It should pass the acceptance criteria of the maintainer or product owner.

Hello,
I fix the patch with new version (in InlineEntityFormComplex.php)

Thanks, Rémi
The patch #16 is working with Inline Entity Form 8.x-1.0-rc15

Attaching at patch file to patch 2.0.0-beta3 and the 2.0.x branch

It appears that the issue fork is outdated.
I am unable to create a new branch for 2.0.x.
If this issue is approved as a new feature, it will likely be committed to the 2.0.x branch.

Thanks, Andrii

Noticed that this feature request was merged and released.
Just to make sure.
Do this need a hook update?
Or the default in code is helping in both cases, old config and new config schema.

• Testing to update from 2.0.0-beta2 to 2.0.0-beta6
• Testing to upgrade from 1.0.0-rc15 to 2.0.0-beta6

I don't think we need a hook update for this
I'd rely on default value
Any concerns from your end?

Thank you, Andrii for following up
Agrees with you, Tested - working very well
No need for hook update.
You can close this issue.

Thank you for the double check
I appreciate

It appears that this fix was applied to the 2.x branch which was then abandoned - issue needs to be reopened.

Edit: It appears that #2913571 has taken the ball for 3.x