Problem
_imagemagick_convert()
calls drupal_realpath()
on the passed-in $source
and $destination
.
drupal_realpath()
can return FALSE
in some conditions, however, and this condition is never checked. One such condition is if the source file is not present which can sometimes happen in dev-stage-prod scenarios. If this happens _imagemagick_convert()
proceeds to call the convert
binary which simply hangs forever causing the site, as well, to hang forever.
Proposed resolution
Early return if drupal_realpath()
returns FALSE
.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2404733-1-imagemagick-realpath.patch | 494 bytes | tstoeckler |
Issue fork imagemagick-2404733
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #1
tstoecklerHere we go.
Comment #2
tstoeckler#brainfail
Comment #3
dgtlmoon CreditAttribution: dgtlmoon commentedComment #4
dgtlmoon CreditAttribution: dgtlmoon commentedAlthough this situation should not occur, I think this is a reasonable safety catch
Comment #5
Chris CharltonBump.
Comment #6
AnybodyConfirming RTBC. Is there an active maintainer for this project?
Comment #7
Chris Charlton+1