Problem

_imagemagick_convert() calls drupal_realpath() on the passed-in $source and $destination.

drupal_realpath() can return FALSE in some conditions, however, and this condition is never checked. One such condition is if the source file is not present which can sometimes happen in dev-stage-prod scenarios. If this happens _imagemagick_convert() proceeds to call the convert binary which simply hangs forever causing the site, as well, to hang forever.

Proposed resolution

Early return if drupal_realpath() returns FALSE.

CommentFileSizeAuthor
#2 2404733-1-imagemagick-realpath.patch494 byteststoeckler
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

Status: Active » Needs review

Here we go.

tstoeckler’s picture

#brainfail

dgtlmoon’s picture

Status: Needs review » Reviewed & tested by the community
dgtlmoon’s picture

Although this situation should not occur, I think this is a reasonable safety catch

Chris Charlton’s picture

Bump.

Anybody’s picture

Confirming RTBC. Is there an active maintainer for this project?

Chris Charlton’s picture

Priority: Normal » Major

+1

DieterHolvoet made their first commit to this issue’s fork.