Right now you can't put FAPE inside a dialog and expect validation errors to work properly. In fact, you can't have ajax submission at all, because the entity_save is in the page handler instead of the form submit callback.

I moved it to the submit callback and it seems to work. Is there something I'm overlooking? If not, I'll submit a patch.

Thanks.

CommentFileSizeAuthor
#2 fape-2657272-2-ajax_fix.patch713 bytescaptainack
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

captainack created an issue. See original summary.

captainack’s picture

captainack CreditAttribution: captainack commented
Issue summary: View changes
Status: Active » Needs review
FileSize
fape-2657272-2-ajax_fix.patch713 bytes

Status: Needs review » Needs work

The last submitted patch, 2: fape-2657272-2-ajax_fix.patch, failed testing.

captainack’s picture

captainack CreditAttribution: captainack commented
Status: Needs work » Needs review

weird... there's no test but it's trying to run one?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

@captainack: It's a known bug in testbot.

captainack’s picture

captainack CreditAttribution: captainack commented
Related issues: +#2716935: Give FAPE's ajax submission the same race condition immunity as non-ajax submission