The span class="element-invisible" tags added by this module contain a space between the tags for mailto and external links. This interferes with the UI if punctuation follows the link text.

Reproduce:
<p>I created this in <a href="http://www.drupal.org">Drupal</a>.</p>

Expected:

I created this in Drupal.

Actual:

I created this in Drupal .

(Spacing inserted before punctuation)

CommentFileSizeAuthor
#13 extlink-spacing-added-between-anchor-text-2864772-13.patch7.19 KBOmar Alahmed
#11 _extlink-removespaces.patch1.03 KBvivify
#9 _extlink-removespaces.patch1.47 KBvivify
#7 _extlink-removespaces.patch4.48 KBvivify
#4 _extlink-removespaces.patch999 bytesvivify
_extlink-removespaces.patch1.07 KBvivify
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vivify created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, _extlink-removespaces.patch, failed testing.

vivify’s picture

vivify CreditAttribution: vivify commented

Sorry new to this. Is it the pathing? Its just removing spaces in 2 lines

vivify’s picture

vivify CreditAttribution: vivify commented
Issue summary: View changes
FileSize
_extlink-removespaces.patch999 bytes
vivify’s picture

vivify CreditAttribution: vivify commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: _extlink-removespaces.patch, failed testing.

vivify’s picture

vivify CreditAttribution: vivify commented
Status: Needs work » Needs review
FileSize
_extlink-removespaces.patch4.48 KB

Status: Needs review » Needs work

The last submitted patch, 7: _extlink-removespaces.patch, failed testing.

vivify’s picture

vivify CreditAttribution: vivify commented
Status: Needs work » Needs review
FileSize
_extlink-removespaces.patch1.47 KB

Status: Needs review » Needs work

The last submitted patch, 9: _extlink-removespaces.patch, failed testing.

vivify’s picture

vivify CreditAttribution: vivify commented
Status: Needs work » Needs review
FileSize
_extlink-removespaces.patch1.03 KB
akalata’s picture

akalata CreditAttribution: akalata commented

Hi vivify, I was not able to confirm any visual changes when using your patch -- I still see the extra space.

But a big THANK YOU for helping me to see the simple solution for me, which is to add display: inline-block to the CSS for span.ext.

Omar Alahmed’s picture

Omar Alahmed
Primary language English
Location Jordan
CreditAttribution: Omar Alahmed at Vardot commented
Assigned: vivify » Unassigned
FileSize
extlink-spacing-added-between-anchor-text-2864772-13.patch7.19 KB

Hi,

extlink.min.js file also has extra space and it's loaded, so it should be included in the patch.

vivify’s picture

vivify CreditAttribution: vivify commented

@akalata Works for me. The source contains with a space between the tags. The patch should remove that.

@Omar Alahmed thanks for remembering the min file.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Needs review » Fixed

It's now committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vivify’s picture

vivify CreditAttribution: vivify commented

Should be re-opened. Subsequent commits overrode this change. Commit #92a73b4966e030f8fad01cb7fdf3359621c0997e

jcmartinez’s picture

jcmartinez
Location Raleigh, NC, USA
CreditAttribution: jcmartinez as a volunteer and at Makers365 commented

Please, reopen this issue. It is still happening.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Closed (fixed) » Active

Submit a patch and I'll add it in.

  • elachlan committed 7b86a3d on 8.x-1.x 
    Issue #2864772 by vivify, Omar Alahmed: Spacing added between anchor...
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Active » Fixed

  • elachlan committed c269b05 on 7.x-1.x 
    Issue #2864772 by vivify, Omar Alahmed, elachlan: Spacing added between...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.