Expose $page argument to entity_view() as a formatter setting [#1995562]

I've written too many alter hooks to get rid of this, so here's a patch to add it as a formatter setting.

The main thing the argument does is control the h2 title in the default entity template, in a lot of cases, that doesn't make and hiding it in a different way requires either custom code or something like Display Suite, which again afaik only works for entities that have an exposed manage display page. I have a whole set of remote entities which are not fieldable and frequently embedded into pages using entity reference.

Not sure if this needs an upgrade path, we could also just make the check conditional :)

Patch coming soon.

Comment	File	Size	Author
#8	entity-reference-page-setting-1995562-8.patch	1.52 KB	Berdir
#8	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Unable to generate test groups
#7	entity-reference-page-setting-1995562-7.patch	1.53 KB	Berdir
#7
#4	entity-reference-page-setting-1995562-4.patch	1.57 KB	Berdir
#4
#4	entity-reference-page-setting-1995562-4-interdiff.txt	579 bytes	Berdir
#3	enitty-reference-page-setting-1995562-3.patch	1.58 KB	Berdir
#3
#1	enitty-reference-page-setting-1995562-1.patch	1.57 KB	Berdir
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Berdir

German

Switzerland

CreditAttribution: Berdir commented 15 May 2013 at 15:47

Status:

Active

» Needs review

File	Size
enitty-reference-page-setting-1995562-1.patch	1.57 KB

Here's a patch, is working nicely for me. Not sure about summary (there's only so much space to show something) and the description that I added. Hard to find a mix of useful information and obvious information as that can of course be said about most settings. But I think it makes sense here as that setting will not do anything for DS'ified entities...

Comment #2

Berdir

German

Switzerland

CreditAttribution: Berdir commented 15 May 2013 at 15:49

Did a !empty() check in formatter_view() so that doesn't result in a notice if not set but just noticed that I forgot to do that in the settings form.

Comment #3

Berdir

German

Switzerland

CreditAttribution: Berdir commented 15 May 2013 at 16:00

File	Size
enitty-reference-page-setting-1995562-3.patch	1.58 KB

Updated that check to use !empty() as well.

Comment #4

Berdir

German

Switzerland

CreditAttribution: Berdir commented 15 May 2013 at 16:03

File	Size
entity-reference-page-setting-1995562-4-interdiff.txt	579 bytes
entity-reference-page-setting-1995562-4.patch	1.57 KB

Actually the setting is the wrong way round.

Comment #5

amateescu CreditAttribution: amateescu commented 19 May 2013 at 15:58

+++ b/entityreference.module
@@ -1076,6 +1077,13 @@ function entityreference_field_formatter_settings_form($field, $instance, $view_
+      '#description' => t('Hide the label of the referenced entity. Only works if not otherwise overwritten.')

Hm, this comment is a bit superfluous.. anything can be overridden :/ Otherwise, this looks good to me.

Comment #6

Berdir

German

Switzerland

CreditAttribution: Berdir commented 19 May 2013 at 18:47

Yes, I wasn't sure about that either. But most other settings at least require code to override it. This is different, using something like panelizer or DS is enough to completely bypass the setting, it only works with the default templates.