Hide "add another item" when queue is full [#3021483]

When specifying a max queue size, users can continue to add more than max items to the queue before they hit save.

Once they click save, an error shows up notifying them they cannot pass the queue size limit. This is okay, but it would be better if instead it just limited the number of item fields to the max size. I.e., if the max is 6, then when I add the 6th item to the list, I shouldn't have an option to add a 7th item.

Comment	File	Size	Author
#3	3021483.patch	740 bytes	amateescu
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

19 December 2018 at 14:59

sagesolutions created an issue. See original summary.

Comment #2

jsheffers CreditAttribution: jsheffers as a volunteer commented 22 February 2019 at 22:47

I agree that this would be a good addition to the module. Furthermore, it would also be helpful in some cases to not show the "Add another button" at all. An example would be a simple entityqueue that has minimum and maximum of 4 items. I only want it to ever contain 4 items. On the edit items screen I would see 4 autocomplete fields and the content could only be replaced with a different reference instead of adding a new item and kicking it out of the queue. Possible?

Comment #3

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented 18 March 2019 at 13:58

Status:

Active

» Fixed

File	Size
3021483.patch	740 bytes

It's very much possible, and quite easy to accomplish too: we can set the cardinality of the items field based on the "max size" setting of the queue :)

Committed the patch attached to 8.x-1.x.

Comment #4

18 March 2019 at 13:58

amateescu committed 44e9635 on 8.x-1.x

Issue #3021483 by sagesolutions, jsheffers: Hide "add another item" when...

Comment #5

1 April 2019 at 13:59

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #6

justcaldwell

he/him

English

Austin, Texas

CreditAttribution: justcaldwell as a volunteer commented 2 April 2019 at 13:27

Just wanted to note a couple of side-effects/regressions that seem to be associated with this change:

This renders the 'Act as queue' feature useless. That feature allows the addition of items over the max to "bump" items off the top of the queue. With this change, it is no longer possible to exceed the maximum number of items. Maybe enforcing cardinality of the items field should be conditional on the 'Act as queue' setting?
In my initial testing, the Autocomplete (draggable table) widget is now broken for queues with a max size. There are no autocomplete fields for unused queue slots, and the 'Remove' buttons for existing queue items do not work. Commenting out the lines introduced by the patch resolved the issues, but I haven't had a chance to debug further.