Comments

wim leers’s picture

Status: Active » Needs review
StatusFileSize
new2.73 KB

Note that this increases the CKEditor requirements: CKEditor 4.1 MUST be used, and it MUST include the "sourcedialog" plugin. README updated.

Same screenshots as at #1964316-1: Automatically use "sourcedialog" plugin/button instead of "sourcearea" plugin/button when using CKEditor for in-place editing apply:

Back-end:

ckeditor-source-backend.png

Front-end (in-place editing), BEFORE patch:

ckeditor-source-frontend-BEFORE.png

Front-end (in-place editing), AFTER patch:

ckeditor-source-frontend-AFTER.png

wim leers’s picture

For the record, this was pointed out at #1906490-20: Default CKEditor toolbar used instead of the CKEditor profile because toolbar configuration not a JS Array. I had intended for this to work this way, but I'd honestly forgotten about it.

dmsmidt’s picture

The readme doesn't reflect the version requirement of CKEdit.
The note about the source button is clear.
Little typ0: "dowwnloaded".

I can confirm that the source button shows up! Good work. It gives a popup (as design I guess).

wim leers’s picture

Yes, that is by design.

Great point about mentioning the version number in the README. I'll definitely do that before commit.

wim leers’s picture

#1964316: Automatically use "sourcedialog" plugin/button instead of "sourcearea" plugin/button when using CKEditor for in-place editing landed, this should be committed. The CKE 4.1 dependency should be documented, and preferably also tested in the status report.

wim leers’s picture

Issue tags: -sprint

That was wrong for a while now.

wim leers’s picture

That was wrong for a while now.

wim leers’s picture

Component: Code » CKEditor
Issue summary: View changes
Status: Needs review » Fixed
Parent issue: » #2111667: Backport Drupal 8's Edit module to Drupal 7

Now implemented, and includes a hook_requirements() addition to automatically check this requirement, but only if the site is actually using the "Source" button.

http://drupalcode.org/project/edit.git/commit/eac85f5

wim leers’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.