Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
Now implemented, and includes a hook_requirements() addition to automatically check this requirement, but only if the site is actually using the "Source" button.
Comments
Comment #1
wim leersNote that this increases the CKEditor requirements: CKEditor 4.1 MUST be used, and it MUST include the "sourcedialog" plugin. README updated.
Same screenshots as at #1964316-1: Automatically use "sourcedialog" plugin/button instead of "sourcearea" plugin/button when using CKEditor for in-place editing apply:
Back-end:
Front-end (in-place editing), BEFORE patch:
Front-end (in-place editing), AFTER patch:
Comment #2
wim leersFor the record, this was pointed out at #1906490-20: Default CKEditor toolbar used instead of the CKEditor profile because toolbar configuration not a JS Array. I had intended for this to work this way, but I'd honestly forgotten about it.
Comment #3
dmsmidtThe readme doesn't reflect the version requirement of CKEdit.
The note about the source button is clear.
Little typ0: "dowwnloaded".
I can confirm that the source button shows up! Good work. It gives a popup (as design I guess).
Comment #4
wim leersYes, that is by design.
Great point about mentioning the version number in the README. I'll definitely do that before commit.
Comment #5
wim leers#1964316: Automatically use "sourcedialog" plugin/button instead of "sourcearea" plugin/button when using CKEditor for in-place editing landed, this should be committed. The CKE 4.1 dependency should be documented, and preferably also tested in the status report.
Comment #6
wim leersThat was wrong for a while now.
Comment #7
wim leersThat was wrong for a while now.
Comment #8
wim leersNow implemented, and includes a
hook_requirements()addition to automatically check this requirement, but only if the site is actually using the "Source" button.http://drupalcode.org/project/edit.git/commit/eac85f5
Comment #9
wim leersFixed small mistake: http://drupalcode.org/project/edit.git/commit/0675f74