Automatically use "sourcedialog" plugin/button instead of "sourcearea" plugin/button when using CKEditor for in-place editing

That's a very good proposal. The "sourcedialog" plugin was created exactly for such use cases (see the whole story in this ticket).

Without caring about IE8 we'd have been able to get rid of the second loop by using .indexOf(), anyway, it's not super pretty but it works.

+++ b/core/modules/ckeditor/js/ckeditor.jsundefined
@@ -55,6 +55,24 @@ Drupal.editors.ckeditor = {
+      for (var i = 0; !sourceButtonFound && i < settings.toolbar.length; i++) {
+        if (settings.toolbar[i] !== '/') {
+          for (var j = 0; !sourceButtonFound && j < settings.toolbar[i].items.length; j++) {
+            if (settings.toolbar[i].items[j] === 'Source') {
+              sourceButtonFound = true;
+              // Swap sourcearea's "Source" button for sourcedialog's.
+              settings.toolbar[i].items[j] = 'Sourcedialog';
+              settingsOverride.extraPlugins += ',sourcedialog';
+              settingsOverride.removePlugins += ',sourcearea';
+            }
+          }

This seems like an awful lot of shenanigans just to change one button.

nod_ explained that the structure of CKEditor's configuration looks like this:

[ [ 'button1', 'button2'], '/' , ['bold', 'sourcedialog'] ]

So there's no way to select on an HTML ID or something similar. Wah-wah.

Otherwise, seems to work well. It pops up the view source in a dialog which is a little funny compared to what it does on the backend (which is replace the text contents), but Alex pointed out that this is how CKEditor works, so I think it's ok.

Committed and pushed to 8.x. Thanks!

Ok got it. Thanks!