I'm not sure where it is getting its button profile from? It is different from the one you see when in normal edit mode. Any way to modify it? Shouldn't it just follow whatever your ckeditor profile is?
Great module I absolutely dig it, soooo awesome! Keep it up!
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | edit-eval_toolbar-1906490-10.patch | 717 bytes | ytsurk |
| #9 | edit-eval_toolbar-1906490-9.patch | 718 bytes | ytsurk |
| #8 | edit-eval_toolbar-1906490-8.patch | 630 bytes | ytsurk |
| #7 | edit-eval_toolbar-1906490-7.patch | 578 bytes | ytsurk |
Comments
Comment #1
sulav commentedI'm having the same problem. Have you found a solution yet? I'll post here if I do find a solution.
Awesome Module BTW.
Comment #2
nod_it should be working, what kind of settings are not kept? (during my testing toolbar buttons and UI color were working).
Comment #3
TelFiRE commentedFrom what I can tell, nothing is kept. Zero of the buttons are correct. I can find no way whatsoever to modify the version of CKEditor that comes up through the "Edit" module. I don't know where it's pulling from as none of my profiles look like what it is giving me.
Comment #4
TelFiRE commentedI'm not sure if it helps at all but I am using the Ckeditor module, not WYSIWYG.
Comment #5
ytsurksame here. for ckeditor4.0.1.1 (full)
edit: same for 4.0, having less buttons as only standart version
with 3.6.6 the quickedit does not show an editor at all.
the color is respected, but it just shows the full profile, even if deleted.
so i guess, i just shows all buttons no matter what ...
2nd edit: problem is that ckeditor module does not add any js_settings etc. to the normal page ...
so - somehow edit module should trigger this ?
3rd edit: this just didn't let me be .. i debugged, and found out that when in
drupalckeditorwidget.js:50i set the settings with the printed property out of console it works.
so fe:
the toolbar is showing.
so it seems to me an string / array confusion ..
jQuery.parseJSON fails, because of the one splitter ('/') not in square bracktes ..
still the used text format is unkown to me, it comes out of
Drupal.edit.metadataCache[propertyID].customas long as I have one format i'm fine ... (didn't trace that for now)
Comment #6
ytsurksolution is to use eval .... so add
settings.toolbar = eval(settings.toolbar);at
sites/all/modules/edit/createjs/editingWidgets/drupalckeditorwidget.js:50be aware: this introduces another vulnerability
(ckeditor is using it as well ..)
Comment #7
ytsurkand here a patch - if you're fine with eval
Comment #8
ytsurkinvalid patch
Comment #9
ytsurkimproved.
making the array when setted, not getted, no longer using evil'd.
should be merged to ckeditor module #1935186: remove eval
Comment #10
ytsurkchanged check from is not array to is stirng
Comment #11
martink commentedI have a test installation with a minimal number of modules enabled, and the Bartik theme. I have a couple of articles on the site, showing as a standard list of teasers (no views) on the front page.
Using 7.x-1.alpha6 the buttons appear to be respected when editing the teaser display, but not when editing the full node
Comment #12
ytsurkdoes my patch from #10 work for you ?
Comment #13
martink commented@ytsurk
Yes it does! Way cool!!!
Comment #14
iztok commentedTested and working fot the 7.x-1.0-alpha6 but not for the latest dev version.
Comment #15
wim leersI don't see how it's possible that this patch works for alpha 6 but not for the latest dev version (645e1af9ef1c4ba0b940412c3d3bd14c360d31ff). None of the changes could have any effect on this AFAIK.
Comment #16
ytsurkme neither ..
Comment #17
AstaC commentedI'm sorry but I don't get it. Where do I find the file to do the patch in?
Comment #18
martink commentedIt's indicated at the beginning of the patch file, but you should find it at /sites/all/modules/edit/js/edit.js
Comment #19
wim leersInvestigated this. This is happening because the CKEditor module uses a weird, non-standard JSON serialization to describe the toolbar configuration. The CKEditor module itself deals with converting this somewhere in the PHP code, because it will output
Drupal.settings.cke_toolbar_Drupal(Advanced|Basic|Full)for its JS to use. Hence the Edit module has to perform a similar conversion.http://drupalcode.org/project/edit.git/commit/952cb59
Comment #20
dmsmidtI can confirm that it works.
However, another question (maybe off topic).
Is it by design that the "source" and "full screen" buttons don't show up?
Comment #21
wim leers#20: When doing in-place editing? Full Screen: yes, by CKEditor's design. Source: as of CKEditor 4.1, it is possible to have the "Source" button show up when doing in-place editing. One must use CKEditor 4.1's "Source Dialog" plugin to achieve that.
However, you're absolutely right that this is not yet implemented here in Drupal 7. This is how we did it in Drupal 8: #1964316: Automatically use "sourcedialog" plugin/button instead of "sourcearea" plugin/button when using CKEditor for in-place editing. I created an issue+patch to do the same in D7 Edit, please review: #1964320: Automatically use "sourcedialog" plugin/button instead of "sourcearea" plugin/button when using CKEditor for in-place editing.
Comment #22
dmsmidtOk everything clear now.
Comment #24
cindyr commentedCommitted? In #19 it shows it was committed, back in March 2013. Doesn't that mean it should be working in the January 2014 full release? It's not, I'm just wondering if I have to use the dev version to get this working.
Comment #25
leo pitt commented@cindyr - ditto - I am finding this problem in both 7.x-1.0 and 7.x-dev
Comment #26
cindyr commentedCan someone shed some light on this issue? It was "committed and closed", but I don't think the patches listed are against 7.0, they appear to be against version 8. Was anything ever provided to fix this in Drupal 7?
Comment #27
wim leers#26: the solution is definitely in the 7.x-1.0 version of Edit: http://drupalcode.org/project/edit.git/blob/5b286e8a91d03d6ab34b3ff9ff63....
None of this is for Drupal 8, because this problem only exists in Drupal 7, since it's related to the Drupal 7 CKEditor module!
If you still have this problem, please create a new issue (and reference this one).
Comment #28
johntang commentedNo need, just set chmod 777 for sites/all/modules/ckeditor/ckeditor.config.js file.