Problem/Motivation

D8 is EOL and upgrade tests are failing on PHP 7.3 and D9.2 so drop D8, D9.2 and PHP 7.3 support

Steps to reproduce

N/A

Proposed resolution

Drop D8, D9.2, and PHP 7.3 support.

Remaining tasks

  • Patch.
  • Agreement.
  • Commit.
  • Release.

User interface changes

None.

API changes

No D8 support or D9.2 supprot.

Data model changes

N/A

CommentFileSizeAuthor
#6 3246916-6.patch865 bytesjibran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

9.2 is the stable version and has support until June next year - shouldn't we retain support for that?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Over the weekend I made the HEAD green on 9.3 with the intention to create a new release once 9.3 is in beta. Fixing the upgrade path tests means that we upgrade path tests will start failing on 9.2 and 9.1. The last release for both 1.x and 2.x is green for those two branches.

Due to the Drupal library upgrades some of the tests are also failing on PHP 7.3 so I think we should drop 7.3 as well as it is EOL by the end of this year anyway.

I will have to update CircleCI config so that we will be running tests on PHP 7.4/8.0 and 9.3 only.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

100% happy with dropping 7.3

I think what you're saying is support 9.2 but no new releases for it.

That's fine with me.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

I think what you're saying is support 9.2 but no new releases for it.

Yup, exactly.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Active » Needs review
FileSize
3246916-6.patch865 bytes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Going to commit this as tests are passing at https://app.circleci.com/pipelines/github/jibran/dynamic_entity_referenc....

  • jibran committed 8a70bfa on 8.x-2.x 
    Issue #3246916 by jibran, larowlan: Drop D8, D9.2, and PHP 7.3 support

  • jibran committed 926defd on 8.x-1.x 
    Issue #3246916 by jibran, larowlan: Drop D8, D9.2, and PHP 7.3 support
dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

What do you think of #3194848: Not possible to run DrupalCI when projects require a PHP version higher than 7.3.0

Are you now ignoring Drupal CI?

I’m sure your opinion will help inform priorities.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed and pushed to 1.x and 2.x

  • jibran committed b623347 on 8.x-2.x 
    Issue #3246916 by dpi: Wait for #3194848 before droping PHP 7.3 support...

  • jibran committed d3a8a0e on 8.x-1.x 
    Issue #3246916 by dpi: Wait for #3194848 before droping PHP 7.3 support...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Thanks for pointing me to the issue. For now, I re-added PHP 7.3 condition.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.