Hi, thanks for this module. Can you please distinguish between the core and Dynamic Entity Reference field type labels? Currently, when adding a field, you see two identical options for every entity type:

adding a dynamic entity reference field

This makes it really hard for the site builder to understand what's going on and what you should choose.

Proposed solution:
Suffix the field type labels with "(Dynamic Entity Reference)". If you translate the suffix separately from the label itself, you can still leverage existing translations. In pseudo code: $field_type_label = $entityType->getLabel() . ' ' . t('(Dynamic Entity Reference)').

CommentFileSizeAuthor
#7 change_the_der_field-2805659-7.patch2.69 KBjibran
#7 interdiff.txt893 bytesjibran
#5 change_the_der_field-2805659-5.patch1.82 KBjibran
#5 DER in dropdown.png26.14 KBjibran
#4 change_the_der_field-2805659-4.patch852 bytesjibran
Selection_020.png33.04 KBmarcvangend
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcvangend created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Title: Distinguish between core and DER field type labels » Change the DER field type group in the field_ui
Version: 8.x-1.0-rc5 » 8.x-1.x-dev
Category: Bug report » Task

Thanks for reporting this. Let's change the group name instead.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
CreditAttribution: marcvangend as a volunteer commented

You're welcome. Grouping them in a separate optgroup sounds like a good idea for this specific form.

That said, there are other places (like /admin/structure/types/manage/NODETYPE/fields) where the field type label is used on its own, without the context of the proposed optgroup. In such a situation, the ambiguity would remain (although it's probably less of a DX problem because it's just info, not a form field). Just my 2 cents.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Active » Needs review
FileSize
change_the_der_field-2805659-4.patch852 bytes

Here we go.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue summary: View changes
FileSize
DER in dropdown.png26.14 KB
change_the_der_field-2805659-5.patch1.82 KB

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

I think the 'Dynamic entity reference' option now needs to say 'Other' and be listed at the end (if possible)

Looks good otherwise

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
FileSize
interdiff.txt893 bytes
change_the_der_field-2805659-7.patch2.69 KB

Nice idea. Here we go.

  • jibran committed 8a1da4e on 8.x-2.x 
    Issue #2805659 by jibran, marcvangend, larowlan: Change the DER field...

  • jibran committed 96438be on 8.x-1.x 
    Issue #2805659 by jibran, marcvangend, larowlan: Change the DER field...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Fixed

Committed and pushed to 8.x-2.x and 8.x-1.x. Thanks!

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
CreditAttribution: marcvangend as a volunteer commented

Thanks jibran!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.