I noticed this in #2490382: Fix typo in EntityQueryTest doc block for figures var.
As a project maintainer for core, when I check the boxes in the crediting field, usually I can make Drupal.org save the credit that I grant reviewers and other contributors who did not author patches. However, in #2490382: Fix typo in EntityQueryTest doc block for figures var, for some reason it will not save the credit I'm trying to credit the issue's original author, @mradcliffe.
I check the box and the commit message gets updated to include him as I expect.
But then once I save the issue, he's unchecked again. Note that it did save the credit I gave @cilefen for reviewing, so it's not totally broken... just partly broken in a way that seems somewhat unexpected.
Comment | File | Size | Author |
---|---|---|---|
mradcliffe.png | 38.7 KB | xjm | |
checking_mradcliffe.png | 69.41 KB | xjm |
Comments
Comment #1
xjmComment #2
xjmNote that by comparison in #2486475: Notifying user of config changes when config has never been synched still makes no sense, it did save credit for me as the author of the original post, but I also commented on the issue. So maybe there is a bug when the individual files the original post, but does not post any further comments?
Comment #3
xjmComment #4
alexpottYep @webchick and I noticed this before. I thought @webchick had filed an issue - I looked for it and could not find it. There is the related #2474609: Not possible to credit people who didn't comment in an issue.
I can confirm that you cannot save the issue creator if they have not commented as a contributor in the credit UI although they are listed.
Comment #5
alexpottThis happened to both @webchick and me on #1923406: Use ASCII character set on alphanumeric fields so we can index all 255 characters whilst trying to credit @sun. Hence comments #128, #129, #130 and #131 - I really do think @webchick might have created an issue but memory and d.o search fails me.
Comment #6
joshuamiThe plan to resolve this—as of right now—is to add an automatic initial comment for the issue author. I'm hoping to get @drumm on this when he is back from vacation next week.
Comment #7
YesCT CreditAttribution: YesCT commentedHere is the issue for that. #2449489: Automatically generate comment when an issue is created
Comment #8
drumm#2449489: Automatically generate comment when an issue is created would indeed solve this. Added it to our staff backlog.