Automatically generate comment when an issue is created

Seems like a good idea.

some (old dreditor pattern?) credited the issue creator after | in the commit message. Now that we can change the summary, it is not quite as clear who to credit, but seems related to #2230579: [meta] Allow crediting reviewers (and other non-coders) as first-class contributors

oops.

something similar got mentioned in #2474609: Not possible to credit people who didn't comment in an issue
that a comment could be automatically made when a committer filled in a field to add people for commit credit purposes...

Something to work around with this is that _node_revision_access() checks for more than one revision existing. If there is just one revision, the "an issue" link goes to 403. The access check is complex enough, I'm not sure about overriding it.

Great, I've done that. Dev examples of this are:

https://ci-drupal.redesign.devdrupal.org/node/2508713
https://ci-drupal.redesign.devdrupal.org/node/2508714

Sure, committed that change.

This will initially double-count the initial comment and the issue posted in the Credit & committing fieldset. The simple way to stop this is to not count the node if it was created after this is deployed to production. Since we don't have that time yet, it will be deployed shortly afterward.

I was developing this with comment render caching turned off. That cache needs to be busted when the initial comment is updated.

Updating the comment's changed timestamp is a good way to do that.

Now in production, #2545608: Request for 'confirmed' role. This hit another edge case, the confirm button is showing.

That and #19 are ready to deploy.

This is all deployed now.

Imo this needs to be rolled back as it is responsible for losing attribution. This comment will be credited to Chapter Three because the last comment I made on d.o was credited to them. I think if I create a new issue the saved attribution will disappear :(

As I expected creating a new issue loses default comment attribution on that issue. I think this should be rolled back as it is new behaviour - #2545886: Provide comment attribution options for the initial automatic issue comment

This messes with the reply count, though, as new issues will automatically have 1 reply listed in issue lists. Or is this what #19 referred to?

#19 is only about the Credit & committing fieldset.

Ironically, this issue was opened to address not being able to see the "new" underneath user pictures for new issues... which this issue didn't actually do (#2446889-15: Display 'new' indicator next to user picture of new users). Half tempted to re-open, but will defer to creating a new issue if that is more desirable.

Let's do a followup issue. A mockup would be appreciated - do we keep some of the system-message-like styling, or none of it?

Ok, I created #2552835: Improve automatically generated issue creation comment. I don't think a mockup is necessary per se. The comment should just be from the user who originally opened the issue. The system message user does not have the picture or the new/confirm meta information a normal user comment would have (nor would it make sense to include that for the system message I think).

Can we change "created an issue" to "reported this issue" ?

Actually this entire issue should be reverted once #2553355: Add "Reported by" and "Created" date to the sidebar on issue pages is in. There is no need to have duplicate information. It also didn't address the original point of this issue.

I still think we need that first comment as mentioned in #2553355: Add "Reported by" and "Created" date to the sidebar on issue pages. It really does give us a good way to quickly confirm a valid user and a way to trigger a comment for issue credits with a small change.

It really does give us a good way to quickly confirm a valid user and a way to trigger a comment for issue credits with a small change.

No. That commit list can easily be modified to simply include the OP (issue author/reporter) as an option. We don't have to "rely" on a comment to add this user to the generated list.

That commit list can easily be modified to simply include the OP (issue author/reporter) as an option.

Except not volunteer/organization/customer. Those are fields on comments. While those aren't exposed yet, the initial comment does get us closer to being able to fill out the whole credit form when creating an issue.

FWIW the automatically generated comment does also add a quick link to the original issue summary (which IS the actual voice of the reporter) and does so in chronological context. I think that helps preserve the original reporter's voice (which some here find valuable) in a way that's compatible with removing the authored by line so that the summary itself is more easily understood to be collaborative.

Except not volunteer/organization/customer. Those are fields on comments.

If the user decides to engage with the issue, they would have the opportunity to change this in the comment yes?

When a user initially creates an issue, they are modifying the issue summary... not a comment. I don't see how determining the "volunteer/organization/customer" status upon issue creation would ever be possible unless the initially issue summary was also the initial comment. That just sounds like a recipe for disaster and confusion.

Including the issue reporter in the credit UI without a comment is not as easy as it would seem. The data model associates credits to comments. To add issue credits without a comment of some sort is going to require quite a bit of rework. To accommodate crediting users that are not involved in the issue thread but contributed (such as a face-to-face conversation at a sprint) will require adding a system comment as well.

@drumm gave this a lot of thought when we were working out a model. Comments were the best way to trace the history of how much participation a person had in the issue.

FWIW the automatically generated comment does also add a quick link to the original issue summary

That could easily be added as a link post rendering of the issue summary itself. It is static information and would never change, it doesn't need to be a comment.

The "See original summary." part is awesome. I'd love to keep this feature just for that.

Can we change "created an issue" to "reported this issue" ?

@kattekrab, I agree.

I've re-opened #2552835: Improve automatically generated issue creation comment to address follow-ups to this issue. Marking this one as fixed.

#2580851: no indicator for credit attribution for comments that are automatically generated when an issue is created

we have a bug. attribution for automatic first comment... should be able to be set when opening the issue, or default to nothing.