If you enable a module, it would be great to get a list of administrative tasks associated with this module instead of the message "The configuration options have been saved".

Inspired by the new "Administer by module"-page I did some work in improving this message.

I think this is quite useful especially for not-so-experienced administrators.

Patch is attached, screenshot will follow.

CommentFileSizeAuthor
#16 module-list-89205-15.patch7.36 KBdrupal_was_my_past
#13 module-list-89205-13.patch1.01 KBdrupal_was_my_past
#5 modulescreen.jpg46.66 KBFrando
#4 system2.patch3.85 KBFrando
#1 screenshot_30.png23.77 KBFrando
modulemessage.patch4.04 KBFrando

Comments

Frando’s picture

Frando commented
StatusFileSize
new screenshot_30.png23.77 KB

Screenshot.

dww’s picture

dww
we/he/they
commented

the only problem with this approach is that the messge is totally transient, and will disappear as soon as the admin does anything else (like click on one of those tempting new links). i'd rather see these links right next to the modules all the time (which was being debated and might already be in core by now, i've been too busy on the new release system to keep up with core checkins for the last week). once that "links" patch goes in (don't know the # off the top of my head), maybe the message in this box should just mention something like: "You can find links to administrative tasks for each new module in the table below" after the list of all the ones that were added...

my $0.02, at least...
-derek

dries’s picture

dries commented

Note sure. Looks nice on the one hand, but bloated on the other hand. Maybe it would be better to link to the correct section of the 'admin/by-module' page? That would simplify things a little, and actually teached people about the existence of that page.

Frando’s picture

Frando commented
StatusFileSize
new system2.patch3.85 KB

Yes, might be true.
So what about something like that?

Frando’s picture

Frando commented
StatusFileSize
new modulescreen.jpg46.66 KB

screenshot

profix898’s picture

profix898 commented
Status: Needs review » Needs work

I really like the new approach. It presents a clearly arranged list of what happened and provides a link to admin-by-module page.
But there are some issue with the patch:

  • Code-style needs work, e.g. foreach() {...} missing braces
  • Messages should be unified, e.g. only disabled/enabled OR has been ... in both cases
    (atm it is 'Module X enabled' and 'Module X has been disabled')
  • Maybe you should create a theme_ function to format the list to make it themable
  • Whats the reason for extracting the admin-by-module code into its own function (system_get_admin_tasks)? You dont need this anymore for the patch, right? But I agree it doesnt hurt and might be used by other modules.

All in all nice patch :)

L4san’s picture

L4san commented
Version: x.y.z » 7.x-dev

Frando: Is this task still in progress?

Moving to cvs.

Frando’s picture

Frando commented
Assigned: Frando » Unassigned

Um, no - I'm travelling currently and therefore unable to do any actual coding. Should be really easy, though.

sutharsan’s picture

sutharsan commented
Component: system.module » usability

Moving all usability issues to Drupal - component usability.

heather’s picture

heather commented
Component: usability » user interface text
Issue tags: +Usability, +ui-text

A slightly related issue: to bring an 'edit configuration' or settings link into the module listing. People on this issue might be interested to review: #598758: Modules page: add link to its settings page for each module

heather’s picture

heather commented
Component: user interface text » other

oops i didn't mean to change component.

Bojhan’s picture

Bojhan commented
Version: 7.x-dev » 8.x-dev

This looks like Drupal 8 work

drupal_was_my_past’s picture

drupal_was_my_past commented
Component: other » user interface text
Assigned: Unassigned » drupal_was_my_past
Status: Needs work » Needs review
StatusFileSize
new module-list-89205-13.patch1.01 KB

I also think this would be a helpful addition. Re-rolled patch for #4.

Status: Needs review » Needs work

The last submitted patch, module-list-89205-13.patch, failed testing.

joachim’s picture

joachim commented

Looks like EnableDisableTestCase::testEnableDisable needs to be changed to account for the new message.

Also, there's stray whitespace in the patch.

But definitely a good thing -- and would save contrib modules from adding these sorts of messages in hook_enable().

drupal_was_my_past’s picture

drupal_was_my_past commented
Status: Needs work » Needs review
StatusFileSize
new module-list-89205-15.patch7.36 KB

Re-rolled patch with updates to appropriate tests.

yoroy’s picture

yoroy commented

Thanks for the reroll. I'm still struggling with applying patches. In the mean time, could somebody update the screenshot? Last we have is this:

the message after enabling modules adds a link to 'show administration options for all modules'

robloach’s picture

robloach
he/him
commented

Related: #1291592: D8UX: Batch API for the Modules page

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Needs work 
<stdin>:61: trailing whitespace.
      drupal_set_message(t('Module <strong>@module</strong> has been <span class="admin-disabled">disabled</span>.', array('@module' => $module)));      
error: core/modules/dashboard/dashboard.test: No such file or directory
error: core/modules/forum/forum.test: No such file or directory
error: patch failed: core/modules/system/system.admin.inc:1194
error: core/modules/system/system.admin.inc: patch does not apply
error: core/modules/system/system.test: No such file or directory

patch no longer applies and has trailing whitespace

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Version: 9.3.x-dev » 9.4.x-dev
Assigned: drupal_was_my_past » Unassigned
Issue summary: View changes
Status: Needs work » Closed (outdated)
Issue tags: -ui-text
Related issues: +#2056089: UI problems on the Modules/Extend page

This was fixed in a later issue #2056089: UI problems on the Modules/Extend page in Drupal 8.0.x. This is a subset of the changes made there so strictly a duplicate.

Closing as outdated.