Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
As part of #3365702: Move SDC Drupal\sdc\Twig to Core namespace some deprecated twig functions were added to Drupal\Core\Template\TwigExtension.
Ensure that these functions are removed as part of 11.0.0.
Steps to reproduce
Proposed resolution
Remaining tasks
Postponed on #3352256: Move code from the experimental SDC module to core
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3409456
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3409456-remove-sdc-deprecated
changes, plain diff MR !7238
1 hidden branch
Comments
Comment #2
e0ipsoThis is postponed until #3352256: Move code from the experimental SDC module to core is merged.
Comment #3
quietone CreditAttribution: quietone at PreviousNext commentedAdding parent.
Comment #4
quietone CreditAttribution: quietone at PreviousNext commentedIssue management.
Comment #5
smustgrave CreditAttribution: smustgrave at Mobomo commentedConsolidating meta
Comment #6
Wim Leers#3352256: Move code from the experimental SDC module to core landed!
Comment #8
plopescCreated MR where SDC module is completely removed from the codebase and references to deprecated twig functions and LibraryDiscoveryParser service parameters BC layer are moved as well.
Comment #9
smustgrave CreditAttribution: smustgrave at Mobomo commentedRemoval seems good/didn't break anything.
Congrats on this one!
Comment #10
catchsdc shouldn't got directly from deprecated to removed, it needs to go to obselete first. That should also come with a post update to uninstall itself. This ensures that the module is uninstalled before it's remove from the filesystem. Otherwise someone who leaves it enabled and updates to Drupal 11 will get a nearly-unrecoverable PHP error about the missing module, and the only way to resolve it is to restore a backup, or manually create a stub so it can be uninstalled cleanly.
Comment #11
plopescThank you for the heads up.
Brought back the SDC module info file stub and added post_update hook to uninstall it.
Finally added section https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol... to reflect the module situation
Comment #12
smustgrave CreditAttribution: smustgrave at Mobomo commentedVerified link https://www.drupal.org/node/3223395#s-sdc correctly goes to SDC
Ran post_update hook locally and it ran fine without issue.
Comment #13
alexpottSorting out issue credit... needs to have 11.x merged in to fix conflicts.
Comment #14
plopescBranch updated with latest changes from 11.x and tests are green again.
Comment #15
smustgrave CreditAttribution: smustgrave at Mobomo commentedRebase appears fine.
Comment #16
alexpottCommitted b8037ac and pushed to 11.x. Thanks!
Comment #18
e0ipso#3412295: Document deprecation in drupal.org documentation pages and #3410387: [11.x] Mark sdc as obsolete for 11.x are both closed by this commit.