Agenda items

Standing items

  • Who is here
  • Any other suggested topics
  • Wins / Thanks / Blockers
  • Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
  • The bug I would most like to see fixed
  • Update on target items from last meeting
  • What should be the initiative focus for the next 2 weeks?

Statistics

Statistics graph

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

larowlan :wave: lee
Griffyn Heels Griff Au
quietone Kia ora!
dww Derek @ TEN7. Currently back in the SF Bay Area for a week, then off to work at California Brazil Camp for 2 glorious weeks of being completely offline (playing live music for incredible dance classes and eating amazing food in an old-growth redwood grove).I'll have to smash bugs this week to make any progress before the next meeting. :sweat_smile: (edited)
mstrelan Michael from Brisbane Australia
lendude Len, Amsterdam
borisson_ Joris, Mechelen
jibran Jibran, AU
smustgrave Stephen, Va-US
Kristen Pol (she/her) Kristen, California, catching up

0️⃣.5️⃣ What’s a good youtube channel you’ve been watching/can share?

larowlan https://www.youtube.com/c/WebConferencesAmsterdam
Griffyn Heels Not Drupal related but I’ve been enjoying these vids recently https://youtu.be/moXgYEaYW54
quietone listening, not watching :slightly_smiling_face: https://www.youtube.com/c/WimMertensOfficial
dww https://www.youtube.com/DerekWrightMusic :wink:
mstrelan https://www.youtube.com/channel/UCwa2SUnyx1dxC6cXtvJAtbA
jibran If you like math like me here is a good one https://www.youtube.com/c/3blue1brown.
Kristen Pol (she/her) I don't watch any YouTube channels but one of my son's recommendations is https://www.youtube.com/c/solarsands
Kristen Pol (she/her) Actually, I do watch this one with my other son and it's fun: https://www.youtube.com/c/AbroadinJapan

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

quietone Have we had feedback from maintainers about if this initiative has helped them or not?
dww Are there any #d10readiness issues that are bugs we could smash before beta deadline?
quietone Most of the work is in tasks but found a few bug with this search on tags.
Kristen Pol (she/her) Probably too late for new topics but IMO at some point it would be interesting to entertain the idea of a global 24 hour bug smash event similar to what we've been doing for D10 porting
dww Great idea, love it! We could either do a bonus 1️⃣ 1️⃣  thread, or put it on the agenda for next meeting.
Griffyn Heels I’ll make an 11. No problemo

2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!

catch Managed to get #1014086: Stampedes and cold cache performance issues with css/js aggregation fixed after 11 years...
Kristen Pol (she/her) Not bugsmash, but new porting event! We're mentoring the leads of this event so they can run it https://www.drupal.org/community/events/drupal-10-global-porting-day-aug...
Kristen Pol (she/her) I just did a bit of triage+closing so I'm feeling a bit better :slightly_smiling_face:

2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you

larowlan thanks to everyone who's kept the initiative going

2️⃣.3️⃣ Blockers - what’s getting in the way of your issues / goals

quietone Still feel like I am catching up after flu/Covid went through the family.
dww Wrapping up a huge project with a big client, other work transitions, travel, family visits, etc.  But I finally have some time this week to catch up on bug smashing again (if getting QuickEdit out of core doesn't eat up all my available contribution effort).
borisson_ I think removing modules is probably the most efficient way of also closing issues because those would also be gone from core's queue
dww But in the case of Quick Edit, we already moved all the issues out of the core queue. :sweat_smile:
dww (back when we thought it was going to be quick and easy :sob: )
Kristen Pol (she/her) work + life + stress + other initiatives :slightly_smiling_face:

2️⃣.4️⃣ :loudspeaker: If you helped with the triage since the last meeting then don’t forget to post a comment to triage issue on d.o.

Griffyn Heels #3301984: [Meta] Bug Smash Initiative triage fortnight commencing 2022-08-02

2️⃣.5️⃣ Approve last fortnight’s minutes

Griffyn Heels #3298724: Meeting of the Bug Smash Initiative 2022-08-02

3️⃣ Core bug statistics - current state of open bugs

quietone Today: 2022-08-16

From: 2022-08-02 to 2022-08-16

All bugs
Open: 51, including 16 fixed
Closed: 80
Age Count
00 22
01 07
02 16
03 07
04 10
05 11
06 05
08 01
10 01

Status Count
closed (fixed) 23
closed (duplicate) 12
closed (won't fix) 2
closed (works as designed) 8
closed (cannot reproduce) 18
closed (outdated) 17

Approximately 280 yr reduction in total number of years of all open bugs.

Only bugs tagged Bug Smash Initiative
Open: 7, including 6 fixed
Closed: 48
Age Count
00 06
01 05
02 09
03 06
04 10
05 08
06 03
08 01

Status Count
closed (fixed) 10
closed (duplicate) 6
closed (works as designed) 5
closed (cannot reproduce) 14
closed (outdated) 13

Approximately 212 yr reduction in total number of years of all open bugs.

quietone Another modest step in the right direction.
quietone Priority (goal): actual
Critical (50): 66
Major (1000): 953
Normal (6000): 4966
Minor (300): 380
dww It's fabulous we're under goal for both major (by a little) and normal (by a lot!).  I'd love for us to do a focus on critical bugs to try to get those under goal, too.
dww Also wonder if we should formally move the goal posts for normal now to be 5000. ;) nah. @quietone is totally right. Bad idea. (edited)
quietone I am not a fan of moving goal posts. When they do, it can hide the work done and have a negative effect on group moral (speaking from experience in another volunteer world). For example, right now we are say, N% below the current normal goal. If the normal goal changes to 5000 then that percentage will be drastically reduced.
quietone I fully support re-evaluating and changing the initiative goals when the initial duration of the initiative has ended. I may be wrong, but I think that is 3 years. (edited)
quietone And I think the start date is, 2020-04-21. Is that right?
Kristen Pol (she/her) Great progress :100:

4️⃣ Lets check back on our targets and set some new ones

Griffyn Heels Looks like the critical is still valid/ being discussed: #2860607: Code execution via Twig templates (including inline) (edited)
Griffyn Heels No update on the major item: https://www.drupal.org/node/2387069
Griffyn Heels Normal was recently updated, ready for pickup: #1937266: BlockContent entities uses delete method instead of pre/postdelete
Griffyn Heels No updates on: https://www.drupal.org/node/3204958
Griffyn Heels I think we can leave these targets for one more meeting, 2/4 have had recent updates.If no progress by the next meeting we can rotate new ones in?
dww IMHO, #2860607 is no longer a bug.  I think we could close it and open a new major task for what's currently being discussed.  I propose we adopt a new critical target now. (edited)
dww Happy to leave the other issues as the targets for 1 more meeting. (edited)
Griffyn Heels Sure, do you mind grabbing a new critical and I can update the link?
dww Do we have a "send me to a random critical" button for that, am I supposed to keep clicking the random triage button until I get a critical one, or do I just get to pick my favorite pet issue? :stuck_out_tongue_winking_eye:
Griffyn Heels Haha yep, just keep clicking
dww Wow, that's way too much clicking without hitting a single critical. :stuck_out_tongue_winking_eye:So I went here, instead: #2550519: Crypt::randomBytes()/drupal_random_bytes() doesn't actually return cryptographically secure random bytes
dww (ugh, although it's currently a D7 issue)
dww First D9 issue is #3066447: [random test failure] Random failures building media library form after uploading image (WidgetUploadTest)
dww (do we want to call random test fail bugs targets?)
dww If random fail bugs aren't really good targets, next in line would be:#3265868: MySQL sql_require_primary_key variable prevents primary keys from being dropped

5️⃣ Help me - Is there anything you could use a :hand:

6️⃣ Let’s look back at PMNMI issues that we can close this fortnight

Kristen Pol (she/her) I don't see any mention of 3 month in the templates: https://www.drupal.org/community-initiatives/bug-smash-initiative/issue-...
Kristen Pol (she/her) Or on the main page https://www.drupal.org/community-initiatives/bug-smash-initiative/workin...
Kristen Pol (she/her) oh, I found it:If we don't receive additional information to help with the issue, it may be closed after three months.

7️⃣ What have you learned in the last fortnight?

mstrelan Getting old. Can't run good and don't recover as quick.
dww Great question!  Thanks for opening this thread.  I need to sign off now, so I'll give this a proper answer in the morning. (edited)
lendude Really starting to use Class constructor property promotion in projects and seeing how much boilerplate it gets rid of
lendude Also, getting old and becoming scared to jump on a skim board :shrug:
Kristen Pol (she/her) I've been old for awhile :laughing: My sons have started playing beach volleyball for fun and I tried it a few days ago and am still sore!

8️⃣ Are we able to refresh the daily triage ticket list? via @darvanen

dww p.s. and can we add links somewhere that send you to random issues restricted by priority so it's easier to find random criticals and majors? ;)
borisson_ I think the first is running the script again and that's something len should be able to do, the second might be a little bit harder?
dww I mean, I could build such functionality directly into project_issue, but that seems like a bad idea and only a short term (?) solution. :stuck_out_tongue_winking_eye:
dww I’m not sure how @lendude’s random button currently works.
borisson_ Not sure how short term that is, we will always have bugs to smash :wink:
dww I meant how short term project_issue is going to be as our platform for tracking bugs.
borisson_ Ah, yeah, that is a good question. I didn't think about that
dww See #gitlab :wink:
lendude Anybody can run the script and just post a MR with the updated list, but yeah it’s not very user friendly so I’ll see if i can run it
borisson_ aha, TIL. I can have a look after work
lendude Just run the php file in phpstorm and it will barf out a list of all bugs, the long list is everything that hasn’t had an update in over a year, the short list is that plus at least 5 years old
lendude But you needs to distill those lists manually from the initial list

9️⃣ Have we had feedback from maintainers about if this initiative has helped them or not? via @quietone

Griffyn Heels Good question, would be great feedback.
Griffyn Heels @larowlan - Anyone you think we could ask? (edited)
larowlan Depends who @quietone is referring to with 'maintainers'
larowlan I feel its had the impact we were hoping for - based on numbers
quietone That would be core maintainers.
larowlan We could post at the g.d.o/core asking for feedback (if that's still a thing)
quietone As a migrate maintainer, I have noticed an issue or two getting triaged that would have otherwise not been touched. That is a positive. And I also started using the 3 month closing suggestion on PMNMI issues. That helped cleared out lingering items. In my head, I keep track of the open number of issues, not just bugs, and migrate has moved from >400 to 380.
dww Agreed with @quietone. As an update.module maintainer, random triage has definitely helped resurface some things that would have otherwise continued to linger, forgotten.  As unofficial co-maintainer of views. datetime, and a handful of other components, seeing some of the same there.I think the targets have been helpful, even if we haven't smashed all of them. :sweat_smile:  Some of the more gnarly issues that are unlikely to get fixed on their own are at least starting to move again.
lendude Same story from a Views maintainer perspective, we dig up stuff that would otherwise not get touched
jibran l feel like shortcut and contact have stayed the same. Not a lot influx of bugs but w/e is there is hard problem and still waiting for a fix. I think the reason is because back in the day before the initiative and before taking up the maintainership we (Lee, Pam, Tobias and I) did triage and closed some issue to clean up the queue.
Griffyn Heels This has been a good thread, I guess the follow on from this is what more can be done?
Kristen Pol (she/her) Maybe we could link to this thread in some of the initiative channels to get more feedback?

🔟 Are there any #d10readiness issues that are bugs we could smash before beta deadline? via @dww

Gábor Hojtsy (he/him) #3302800: Core tests need to filter out deprecated themes when looping over all themes is a good one to look at IMHO

1️⃣ 1️⃣ It would be interesting to entertain the idea of a global 24 hour bug smash event similar to what we’ve been doing for D10 porting via @Kristen Pol (she/her)

Kristen Pol (she/her) Thanks @Griffyn Heels! :slightly_smiling_face:
Kristen Pol (she/her) I think I'm too swamped for the next few weeks but I'd love feedback on this idea to see if it's something maybe that could be done post-DrupalCon?
Kristen Pol (she/her) October or November?
larowlan perhaps coincide with sprint day at DrupalSouth?
larowlan Are you making the trek down under for DrupalSouth Kristen?
Griffyn Heels The sprint day is 21/10
dww Aww, sounds amazing!  Wish I could join y'all down under, but I'll be in Florida visiting family that weekend. Perhaps a little bit of remote smashing would be possible for me.  I could also send it around @ TEN7 and see if we can get some more smashers that way...
darvanen I am in favour of this idea, particularly tied in with DrupalSouth
Kristen Pol (she/her) @larowlan I'd love to go to DrupalSouth but we are coming to Australia in Dec+Jan :slightly_smiling_face:
Kristen Pol (she/her) I also love the idea of tying to DrupalSouth if y'all are keen!

Participants:

larowlan, Griffyn Heels, quietone, dww, mstrelan, jibran, Kristen Pol, catch, borisson_, lendude, Gábor Hojtsy, darvanen

Comments

quietone created an issue. See original summary.

griffynh’s picture

Issue summary: View changes

larowlan credited catch.

larowlan credited darvanen.

larowlan credited dww.

larowlan credited jibran.

larowlan credited Lendude.

larowlan credited mstrelan.

larowlan credited paulocs.

larowlan’s picture

larowlan’s picture

smustgrave’s picture

Status: Active » Reviewed & tested by the community

Looks correct to me

lendude’s picture

Status: Reviewed & tested by the community » Fixed

Agreed, looks good

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.