Ignore: patch testing issue for PHP 8.2 attributes

added #2839195-63: Add a method to access the original property

2,581 failed

Added
- #3274474: Fix 'Access to an undefined property' PHPStan L0 errors
- #3298396: Upgrade composer requirement to 2.3.6 to prevent warnings on PHP 8.2
- #3298343: upgrade egulias/email-validator to 3.2.1 to support PHP 8.2

2,205 failed

this should fix lots of tests, probably needs new issue

1,907 failed

a bit more properties

1,796 failed

more migration tests will pass

Fix ConfigurationTest and BlockHtmlTest (weird public property \Drupal\Core\Session\UserSession::$sessionId)

fix #12

stub phpcs

1,680 failed

remove modules/views_ui/src/ViewUI.php.orig

1,680 failures

fir remaining callables and core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityBaseUnitTest.php

one more undefined property

Fix CS for #17

1,445. Failed

Setting #[AllowDynamicProperties] on ConfigEntityBase

948 failed

\Drupal\views\Plugin\views\PluginBase got annotation

940 failed

More fixes for views

416 failed

Lots of errors because

1) Drupal\Tests\field_ui\Functional\ManageFieldsFunctionalTest::testDefaultValue
Exception: Deprecated function: Creation of dynamic property Symfony\Component\Validator\ConstraintViolation::$arrayPropertyPath is deprecated
Drupal\Core\Field\WidgetBase->flagErrors()() (Line: 452)

sounds like needs drupal-wrapper class to use custom property

Another strange runs

-

1) Drupal\Tests\layout_builder\Functional\LayoutBuilderSectionStorageTest::testRenderByContextAwarePluginDelegate
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "overrides" plugin does not exist. Valid plugin IDs for Drupal\layout_builder\SectionStorage\SectionStorageManager are: overrides, layout_builder_test_state, test_simple_config, defaults

-

Unsilenced deprecation notices (3)

  1x: Creation of dynamic property Drupal\Tests\system\Functional\FileTransfer\TestFileTransfer::$jail is deprecated
    1x in FileTransferTest::testJail from Drupal\Tests\system\Functional\FileTransfer

  1x: Creation of dynamic property Drupal\Tests\system\Functional\FileTransfer\TestFileTransfer::$chroot is deprecated
    1x in FileTransferTest::testJail from Drupal\Tests\system\Functional\FileTransfer

  1x: Creation of dynamic property Drupal\Tests\system\Functional\FileTransfer\TestFileTransfer::$connection is deprecated
    1x in FileTransferTest::testJail from Drupal\Tests\system\Functional\FileTransfer

Fix mostly all rest and content translation tests

Fix CS

Few tests fail with similar

1) Drupal\Tests\node\Kernel\Migrate\d7\MigrateNodeRevisionTest::testNodeRevisions
Attempt to create a field storage comment_body with no type. (/var/www/html/core/modules/field/src/Entity/FieldStorageConfig.php:261)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'status'
+'error'

Remaining self deprecation notices (82)

  27x: Creation of dynamic property Mock_EntityBase_7c3ee2dd::$id is deprecated
    27x in EntityUnitTest::setUp from Drupal\Tests\Core\Entity

  27x: Creation of dynamic property Mock_EntityBase_7c3ee2dd::$langcode is deprecated
    27x in EntityUnitTest::setUp from Drupal\Tests\Core\Entity

  27x: Creation of dynamic property Mock_EntityBase_7c3ee2dd::$uuid is deprecated
    27x in EntityUnitTest::setUp from Drupal\Tests\Core\Entity

  1x: Creation of dynamic property Mock_EntityBase_7c3ee2dd::$label is deprecated
    1x in EntityUnitTest::testLabel from Drupal\Tests\Core\Entity

mocks needs separate issue

fix CS again

223 failed

Still not clear what todo with constraints

Testing Drupal\KernelTests\Core\Entity\FieldWidgetConstraintValidatorTest
...                                                                 3 / 3 (100%)

Time: 00:06.311, Memory: 4.00 MB

OK (3 tests, 25 assertions)

Unsilenced deprecation notices (12)

  12x: Creation of dynamic property Symfony\Component\Validator\ConstraintViolation::$arrayPropertyPath is deprecated
    7x in FieldWidgetConstraintValidatorTest::testValidationWithCompositeConstraint from Drupal\KernelTests\Core\Entity
    3x in FieldWidgetConstraintValidatorTest::testValidation from Drupal\KernelTests\Core\Entity
    2x in FieldWidgetConstraintValidatorTest::testEntityLevelConstraintValidation from Drupal\KernelTests\Core\Entity

186 failed

Fix few more test

Lots of migrations are fails because of

1) Drupal\Tests\menu_link_content\Kernel\Migrate\d6\MigrateMenuLinkTest::testMenuLinks
PHPUnit\Framework\Exception: PHP Fatal error:  Uncaught LogicException: Settings can not be serialized. This probably means you are serializing an object that has an indirect reference to the Settings object. Adjust your code so that is not necessary. in /var/www/html/core/lib/Drupal/Core/Site/Settings.php:81

Tricky one \Drupal\Tests\views\Kernel\ModuleTest::testLoadFunctions()

162 failed

one more callable to make \Drupal\Tests\views\Kernel\ModuleTest::testLoadFunctions() pass

168

added #3204929-15: Html::load() inconsistent space removal with old libxml2 versions. and #3298199-3: Upgrade phpstan/phpstan to 1.8.2 for support of PHP 8.2 #[\AllowDynamicProperties] attribute

162

Added #3298821: Remove test that tests drupal/core-composer-scaffold when it is not allowed

looks random 167 failed

Using #3298821-9: Remove test that tests drupal/core-composer-scaffold when it is not allowed

interdiff vs #34

162 failed

Fixed \Drupal\Tests\Core\Test\TestSetupTraitTest - needs new issue

162

Added #3298731-6: Using ConstraintViolation::$arrayPropertyPath bugs on PHP 8.2 as workaround and fix CS as #39

125 fails

Field_layout.Drupal\Tests\field_layout\FunctionalJavascript\FieldLayoutTest
vs
Media_library.Drupal\Tests\media_library\FunctionalJavascript\WidgetOEmbedTest

fails randomly

Using #3298821-11: Remove test that tests drupal/core-composer-scaffold when it is not allowed

126

Filed #3298923: Fix ProtectedUserFieldConstraintValidatorTest to not trigger deprecations on PHP 8.2

and one more property for View

Fix CS

127

one more fix for mocks

122

another mock

121

upgrade of https://github.com/sirbrillig/phpcs-variable-analysis/releases/tag/v2.11.4 and clean-up patch

pick latest patch from #2531564-197: Fix leaky and brittle container serialization solution

re-roll and fix on release https://github.com/bovigo/vfsStream/releases/tag/v1.6.11-alpha.0

116 fails

2 less

116 fails

following fails randomaly

Claro.Drupal\FunctionalJavascriptTests\Theme\ClaroEntityDisplayTest.Drupal\FunctionalJavascriptTests\Theme\ClaroEntityDisplayTest
    Claro.Drupal\FunctionalJavascriptTests\Theme\ClaroEntityDisplayTest.Unknown

    Javascript.Drupal\FunctionalJavascriptTests\Tests\JSWebWithWebDriverAssertTest.Drupal\FunctionalJavascriptTests\Tests\JSWebWithWebDriverAssertTest

    Quickedit.Drupal\Tests\quickedit\FunctionalJavascript\QuickEditFileTest.Drupal\Tests\quickedit\FunctionalJavascript\QuickEditFileTest
    Quickedit.Drupal\Tests\quickedit\FunctionalJavascript\QuickEditFileTest.Unknown

re-roll

check only composer updates

2,993 failed

patch with composer and annotations

2,976 failed

- https://github.com/bovigo/vfsStream/releases/tag/v1.6.11-alpha.0 is required to pass ViewsEntitySchemaSubscriberIntegrationTest

Without stable release the branch will fail as we have a test for required stability <=1

re-roll after #3298343: upgrade egulias/email-validator to 3.2.1 to support PHP 8.2

2,993

Added #3299327: Replace deprecated static::method() calls for PHP 8.2

upgrade of mglaman/phpstan-drupal

re-roll #51 - 116 fails

re-roll after composer deps are done #3295520: Update dependencies for Drupal 10.0 and 9.5

112 failed

re-roll after #3298923: Fix ProtectedUserFieldConstraintValidatorTest to not trigger deprecations on PHP 8.2

110 failed

Fixed #3299853: Apply #[\AllowDynamicProperties] attribute to base classes to make PHP 8.2 log size sane

so removed clean-up

Needs reroll

109 failed

Added #3299828: Stop storing Settings singleton in object properties

Using #3299828-30: Stop storing Settings singleton in object properties

the patch

re-roll after commit of #3298906: Fix \Drupal\Tests\Core\Test\TestSetupTraitTest::testChangeDatabasePrefix() on PHP 8.2 with #3299828: Stop storing Settings singleton in object properties

23 failed

without settings-addition

24 failed

2 fixed tests

re-roll

Filed #3308744: Fix magic connection property access from \Drupal\Core\FileTransfer\FileTransfer::__get()

fix CS

#3308744-3: Fix magic connection property access from \Drupal\Core\FileTransfer\FileTransfer::__get()

20 failed

re-roll after #2531564: Fix leaky and brittle container serialization solution

commited #3274474: Fix 'Access to an undefined property' PHPStan L0 errors

1906 fails

There's more fixes then 3 issues in summary

Rebased changes and replaced patch #24 with #48 from #3298731: Using ConstraintViolation::$arrayPropertyPath bugs on PHP 8.2

Added missing 2 files, interdiff vs #87

20 fails

Let's see how it went without #2839195: Add a method to access the original property

829 fails

Thank you, fixed #91.1 and gonna file new issues for other points

23 failed

Using #92

Re #91 filed 3 issues

2/3/5/7) filed #3309748: Define missing object properties on non-testing classes for PHP 8.2

4) #3309745: Fix dynamic property deprecations and other unit test failures for PHP 8.2

6) #3309750: Fix callable syntax for PHP 8.2 in Views.php

8) we need to define the property to prevent following errors but when I define property with underscore then sniffers does not pass
So I defined property without underscore and changed usage of old one to new

9x: Creation of dynamic property Drupal\Tests\Component\DependencyInjection\MockService::$_someProperty is deprecated
    1x in ContainerTest::testGet from Drupal\Tests\Component\DependencyInjection
    1x in ContainerTest::testGetForSerializedServiceDefinition from Drupal\Tests\Component\DependencyInjection
    1x in ContainerTest::testGetForNonExistentParameterDependency from Drupal\Tests\Component\DependencyInjection
    1x in ContainerTest::testGetForParameterDependencyWithExceptionOnSecondCall from Drupal\Tests\Component\DependencyInjection
    1x in ContainerTest::testGetForNonExistentParameterDependencyWithException from Drupal\Tests\Component\DependencyInjection

The remaining 17 failures mostly caused by

Exception: Deprecated function: Creation of dynamic property
Drupal\Core\Config\Entity\ConfigEntityType::$label_callback is deprecated

fix unserialize, not clear where $label_callback and others from interdiff are used

re-rolled after #3298731: Using ConstraintViolation::$arrayPropertyPath bugs on PHP 8.2

Workaround from #92

\Drupal\views\ViewExecutable::$live_preview needs more work, wanna see how many tests will fail

Attempt to use attribute

Moved fixes for #92

- 2-3 to #3299857-3: [PP-1] Remove AllowDynamicProperties attribute from ConfigEntityBase (interdiff with this changes removed)
- 4,5,8 #3309745-3: Fix dynamic property deprecations and other unit test failures for PHP 8.2
- 7 #3309748-3: Define missing object properties on non-testing classes for PHP 8.2

let's see if User entity allows extra property

So #92.3 is required

Running PHPStan on *all* files.
 ------ --------------------------------------------------------- 
  Line   core/lib/Drupal/Core/Entity/EntityDisplayBase.php        
 ------ --------------------------------------------------------- 
  546    Access to an undefined property                          
         Drupal\Core\Entity\EntityDisplayBase::$_serializedKeys.  
  556    Access to an undefined property                          
         Drupal\Core\Entity\EntityDisplayBase::$_serializedKeys.  
 ------ --------------------------------------------------------- 

- #3309745-9: Fix dynamic property deprecations and other unit test failures for PHP 8.2
and
- #3309748-11: Define missing object properties on non-testing classes for PHP 8.2

Other way to fix "sqlQuery"

one more mock (and remaining 8 failures are passed with patched PHP for parse_url)

used #3311562: Set sqlQuery in Entity\Query\Sql Condition classes on own class

test for 9.5

2803 failed

nor clear why 9.5.x is so different

631 failed