Upgrade composer requirement to 2.3.6 to prevent warnings on PHP 8.2 [#3298396]

Problem/Motivation

Before 2.3.6 composer throws to logs

> Drupal\Core\Composer\Composer::upgradePHPUnit
PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /var/www/html/vendor/composer/composer/src/Composer/Autoload/AutoloadGenerator.php on line 881
PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /var/www/html/vendor/composer/composer/src/Composer/Autoload/AutoloadGenerator.php on line 886
PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /var/www/html/vendor/composer/composer/src/Composer/Autoload/AutoloadGenerator.php on line 881
PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /var/www/html/vendor/composer/composer/src/Composer/Autoload/AutoloadGenerator.php on line 886

Steps to reproduce

https://github.com/composer/composer/commit/c27dca83ef21bd44c41c1a60dd2e... fixes it

see https://dispatcher.drupalci.org/job/drupal_patches/138522/artifact/jenki...

Proposed resolution

require ^2.3.6 and upgrade composer to 2.3.10

Remaining tasks

review/commit

User interface changes

API changes

Data model changes

Release notes snippet

Drupal 10 requires Composer version 2.3.6 or higher to support Automatic Updates and PHP 8.2. Core developers must update to at least Composer 2.3.6 to work on Drupal core, and site owners may also receive a warning or error about older Composer versions in the future.

Comment	File	Size	Author
#18	3298396-18.patch	2.34 KB	andypost
#18	9.5.x: PHP 8.1 & MySQL 5.7 30,063 pass
#12	3298396-12-10.1.patch	5.4 KB	andypost
#12	10.1.x: PHP 8.1 & MySQL 5.7 28,579 pass
#9	interdiff.txt	907 bytes	andypost
#8	3298396-8.patch	5.4 KB	andypost
#8	10.0.x: PHP 8.1 & MySQL 5.7 28,576 pass 10.1.x: PHP 8.1 & MySQL 5.7 Checkout Error PHP 8.1 & MySQL 5.7 Patch Failed to Apply
#4	3298396-4.patch	4.51 KB	andypost
#4	10.0.x: PHP 8.1 & MySQL 5.7 28,576 pass 10.1.x: PHP 8.1 & MySQL 5.7 28,579 pass
#3	After patch.png	24.93 KB	ameymudras
#3	Before patch.png	120.45 KB	ameymudras
#2	3298396-2.patch	3.09 KB	andypost
#2	10.0.x: PHP 8.1 & MySQL 5.7 28,566 pass PHP 8.2 & MySQL 8 CI aborted 10.1.x: PHP 8.1 & MySQL 5.7 28,567 pass
	run_testserror.txt	740 bytes	andypost

Issue fork drupal-3298396

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3298396-upgrade-composer-requirement compare
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

19 July 2022 at 14:37

andypost created an issue. See original summary.

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 19 July 2022 at 14:38

Status:

Active

» Needs review

File	Size
3298396-2.patch	3.09 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,566 pass PHP 8.2 & MySQL 8 CI aborted 10.1.x: PHP 8.1 & MySQL 5.7 28,567 pass

File

Size

3298396-2.patch

3.09 KB

10.1.x:
PHP 8.1 & MySQL 5.7 28,567 pass

the patch

Comment #3

ameymudras CreditAttribution: ameymudras at Salsa Digital commented 22 July 2022 at 11:51

File	Size
Before patch.png	120.45 KB
After patch.png	24.93 KB

Thanks Andy,

Patch applies cleanly.
Title and issue summary are clear.
Change is simple and addresses the issue from the issue summary.
Issue metadata looks okay.

+1 for RTBC

Comment #4

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 July 2022 at 08:10

Title:

Upgrade composer to 2.3.10 to prevent warnings on PHP 8.2

» Upgrade composer requirement to 2.3.6 to prevent warnings on PHP 8.2

File	Size
3298396-4.patch	4.51 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,576 pass 10.1.x: PHP 8.1 & MySQL 5.7 28,579 pass

File

Size

3298396-4.patch

4.51 KB

10.0.x:
PHP 8.1 & MySQL 5.7 28,576 pass

10.1.x:
PHP 8.1 & MySQL 5.7 28,579 pass

2 files were hidden/shown/deleted

File	Size
Before patch.png	120.45 KB
After patch.png	24.93 KB

As commit in IS explains the required version is at least 2.3.6 (currently core requiring 2.3.5)

So improve title and newer patch to bump requirement as well

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 July 2022 at 18:53

Issue summary:

View changes

fixed IS

Comment #6

25 July 2022 at 19:46

Vighneshh made their first commit to this issue’s fork.

Comment #7

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 26 July 2022 at 06:36

Unsure myself, but since we're bumping the composer version in the root composer.json from 2.3.5 to 2.3.6, shouldn't we also be doing this in \Drupal\Composer\Composer::ensureComposerVersion?

Comment #8

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 26 July 2022 at 06:47

File

Size

3298396-8.patch

5.4 KB

10.0.x:
PHP 8.1 & MySQL 5.7 28,576 pass

10.1.x:
PHP 8.1 & MySQL 5.7 Checkout Error
PHP 8.1 & MySQL 5.7 Patch Failed to Apply

3 files were hidden/shown/deleted

File	Size
run_testserror.txt	740 bytes
3298396-2.patch	3.09 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,566 pass PHP 8.2 & MySQL 8 CI aborted 10.1.x: PHP 8.1 & MySQL 5.7 28,567 pass
3298396-4.patch	4.51 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,576 pass 10.1.x: PHP 8.1 & MySQL 5.7 28,579 pass

Good catch, fixed

Comment #9

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 26 July 2022 at 06:48

File	Size
interdiff.txt	907 bytes

interdiff for #8

Comment #10

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 26 July 2022 at 13:13

Status:

Needs review

» Reviewed & tested by the community

Thanks @andypost, created #3299984: \Drupal\Tests\Composer\ComposerTest::testEnsureComposerVersion not testing what we expect. as a spin-off issue since that test still passes without being changed.

This issue is RTBC for me:
- composer/composer min version in composer.json is raised to 2.3.6,
- composer.lock gets version 2.3.10, which is what would happen in an Update-All-The-Dependency-Things!-issue just before the official release anyway.
- \Drupal\Composer\Composer::ensureComposerVersion ups its min version to 2.3.6 as well.

I _think_ we can fix/delete the test mentioned in the first sentence in that separate issue?

Comment #11

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 26 July 2022 at 13:23

Status:

Reviewed & tested by the community

» Needs work

Crap, we actually need a separate 10.1.x version of the patch. (Wonder how patch #4 got away with just a single patch for both branches). Sorry, back to NW.

Comment #12

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 27 July 2022 at 06:46

File	Size
3298396-12-10.1.patch	5.4 KB
10.1.x: PHP 8.1 & MySQL 5.7 28,579 pass

patch for 10.1.x

Comment #13

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 27 July 2022 at 06:47

Status:

Needs work

» Needs review

Comment #14

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 27 July 2022 at 07:48

Status:

Needs review

» Reviewed & tested by the community

Thanks @andypost, back to RTBC (see #10)

Comment #15

27 July 2022 at 13:11

catch committed fe32bc3 on 10.0.x

Issue #3298396 by andypost, Vighneshh, ameymudras, Spokje: Upgrade...

Comment #16

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 27 July 2022 at 13:11

Version:	10.0.x-dev	» 9.5.x-dev
Status:	Reviewed & tested by the community	» Needs work

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

I think we could do with a 9.5.x version here that bumps the version but not the requirement.

Comment #17

27 July 2022 at 13:12

catch committed f3a0d34 on 10.1.x

Issue #3298396 by andypost, Vighneshh, ameymudras, Spokje: Upgrade...

Comment #18

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 27 July 2022 at 13:23

Status:

Needs work

» Needs review

File	Size
3298396-18.patch	2.34 KB
9.5.x: PHP 8.1 & MySQL 5.7 30,063 pass

3 files were hidden/shown/deleted

File	Size
3298396-8.patch	5.4 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,576 pass 10.1.x: PHP 8.1 & MySQL 5.7 Checkout Error PHP 8.1 & MySQL 5.7 Patch Failed to Apply
interdiff.txt	907 bytes
3298396-12-10.1.patch	5.4 KB
10.1.x: PHP 8.1 & MySQL 5.7 28,579 pass

Bump for 9.5 makes sense as at least the commit fixes weird behavior https://github.com/composer/composer/commit/3ebd66b85108e5da3585371aa1de...

Anyway bumping version without requirement (FYI the commit from IS exists in 2.2.13 so 9.5.x is not affected by the bug)

Comment #19

27 July 2022 at 14:24

Status:

Needs review

» Needs work

The last submitted patch, 18: 3298396-18.patch, failed testing. View results

Comment #20

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 27 July 2022 at 17:40

Do we really want to update composer/composer from "2.2.14" to "2.2.17" in an issue originally about bumping "2.3.5" to "2.3.10"?

Besides that: The main reason was originally to get PHP 8.2 working, which seems untestable on 9.x branches?
More importantly: 2.2.14 seems already PHP 8.2 ready: https://github.com/composer/composer/releases/tag/2.2.13

Not saying we shouldn't update composer/composer, but saying I don't think we should be doing it in this issue for PHP 8.2 reasons.
Dunno *shrug*

Comment #21

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 27 July 2022 at 18:44

Status:

Needs work

» Needs review

CI was broken

Re #20 as 9.5 is in development I find it handy to bump all dependenies but maybe for that case it makes sense to file follow-up to update other ones as well a-la #3295520: Update dependencies for Drupal 10.0 and 9.5

Comment #22

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 27 July 2022 at 23:02

Version:	9.5.x-dev	» 10.0.x-dev
Status:	Needs review	» Fixed

Yes I didn't realise 9.5.x already had the composer commit we needed here, fine to do the update in a general update dependencies issue I think. Moving this one back to fixed against 10.0.x

Comment #23

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 3 August 2022 at 02:02

Issue tags:

+10.0.0 release notes

Comment #24

17 August 2022 at 02:04

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #25

phenaproxima

he/him

English

Massachusetts

CreditAttribution: phenaproxima at Acquia commented 8 September 2022 at 19:53

Status:	Closed (fixed)	» Needs work
Issue tags:		+Needs release note

I think the release note could be a little more detailed. What are the implications/impact? Will people be able to even use Drupal (or create new sites) with Composer <2.3.6? Let's elaborate on that a bit.

Comment #26

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 16 September 2022 at 23:34

Issue summary:	View changes
Status:	Needs work	» Needs review

Changed it to wording from release notes

Drupal 10 requires Composer version 2.3.6 or higher to support Automatic Updates and PHP 8.2. Core developers must update to at least Composer 2.3.6 to work on Drupal core, and site owners may also receive a warning or error about older Composer versions in the future