Problem/Motivation

Before this version package is using utf8_decode() which is deprecated in 8.2

the package is listed in core/composer.json as "egulias/email-validator": "^2.1.22|^3.1" so as 2.x is EOL since January 2022 for 10.0.x we can bump it to ^3.2.1 https://github.com/egulias/EmailValidator/blob/3.x/README.md#supported-v...

Steps to reproduce

See https://github.com/egulias/EmailValidator/commit/f88dcf4b14af14a98ad96b1... where it was fixed

Proposed resolution

Upgrade to 3.2.1 as this commit included

Remaining tasks

patch/reviw/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

10.x
egulias/email-validator upgraded to 3.2.1, support for 2.1 is removed as the version no longer supported by upstream

9.5.x
egulias/email-validator has been upgraded to 3.2.1

Comments

andypost created an issue. See original summary.

andypost’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new2.28 KB

the patch

andypost’s picture

StatusFileSize
new1.15 KB
new3.41 KB

Probably it should be fine for 10.0.x

andypost’s picture

Issue summary: View changes

2.x is unsupported since January 2022 so removal makes sense

https://github.com/egulias/EmailValidator/blob/3.x/README.md#supported-v...

Added to IS

Status: Needs review » Needs work

The last submitted patch, 3: 3298343-3.patch, failed testing. View results

andypost’s picture

Status: Needs work » Needs review

Re-queued, failure looks unrelated https://www.drupal.org/pift-ci-job/2430741

1) Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testViewMode with data set "without alignment" (false)
Behat\Mink\Exception\ElementNotFoundException: Element matching css "article.media--view-mode-view-mode-1" not found.
andypost’s picture

Issue summary: View changes

fixed release note

catch’s picture

Priority: Normal » Critical
Issue tags: +Drupal 10 beta blocker
spokje’s picture

Status: Needs review » Reviewed & tested by the community

LGTM, dropping 2.x support makes sense since it's unsupported and it only will be done in a new major release of Core.

  • catch committed 5acb94c on 10.0.x
    Issue #3298343 by andypost, Spokje: upgrade egulias/email-validator to 3...
  • catch committed fa81e93 on 10.1.x
    Issue #3298343 by andypost, Spokje: upgrade egulias/email-validator to 3...
catch’s picture

Version: 10.0.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: +Needs reroll

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks! Makes sense to increase the constraint on 10.0.x.

I think we probably should probably backport just the version update without the constraint increase to 9.5.x

spokje’s picture

StatusFileSize
new2.28 KB

"Interestingly" 9.5.x was on a higher version of egulias/email-validator (3.2) than 10.x (3.1.2)

spokje’s picture

Status: Patch (to be ported) » Needs review
Issue tags: -Needs reroll +10.0.0 release notes
andypost’s picture

Status: Needs review » Reviewed & tested by the community

yes, it's interesting why D10 used to allow 2.x

  • catch committed ab77cf9 on 9.5.x
    Issue #3298343 by andypost, Spokje: upgrade egulias/email-validator to 3...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Hmm. Wondering if we missed a 10.x commit somewhere, maybe a pre-9.4 dependency update that never had a 10.x version?

Either way, committed ab77cf9 and pushed to 9.5.x. Thanks!

catch’s picture

Issue summary: View changes
Issue tags: +9.5.0 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.