Problem/Motivation
Before this version package is using utf8_decode() which is deprecated in 8.2
the package is listed in core/composer.json as "egulias/email-validator": "^2.1.22|^3.1" so as 2.x is EOL since January 2022 for 10.0.x we can bump it to ^3.2.1 https://github.com/egulias/EmailValidator/blob/3.x/README.md#supported-v...
Steps to reproduce
See https://github.com/egulias/EmailValidator/commit/f88dcf4b14af14a98ad96b1... where it was fixed
Proposed resolution
Upgrade to 3.2.1 as this commit included
Remaining tasks
patch/reviw/commit
User interface changes
no
API changes
no
Data model changes
no
Release notes snippet
10.x
egulias/email-validator upgraded to 3.2.1, support for 2.1 is removed as the version no longer supported by upstream
9.5.x
egulias/email-validator has been upgraded to 3.2.1
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 3298343-d95-13.patch | 2.28 KB | spokje |
| #3 | 3298343-3.patch | 3.41 KB | andypost |
| #3 | interdiff.txt | 1.15 KB | andypost |
| #2 | 3298343-2.patch | 2.28 KB | andypost |
Comments
Comment #2
andypostthe patch
Comment #3
andypostProbably it should be fine for 10.0.x
Comment #4
andypostIt was upgraded to 3.1 in #3281578: Increase Composer dependency constraints to latest minors for forward-compatibility
v3.0 added in #3238763: Upgrade egulias/email-validator to v3
Comment #5
andypost2.x is unsupported since January 2022 so removal makes sense
https://github.com/egulias/EmailValidator/blob/3.x/README.md#supported-v...
Added to IS
Comment #7
andypostRe-queued, failure looks unrelated https://www.drupal.org/pift-ci-job/2430741
Comment #8
andypostfixed release note
Comment #9
catchComment #10
spokjeLGTM, dropping 2.x support makes sense since it's unsupported and it only will be done in a new major release of Core.
Comment #12
catchCommitted/pushed to 10.1.x and cherry-picked to 10.0.x, thanks! Makes sense to increase the constraint on 10.0.x.
I think we probably should probably backport just the version update without the constraint increase to 9.5.x
Comment #13
spokje"Interestingly"
9.5.xwas on a higher version ofegulias/email-validator(3.2) than10.x(3.1.2)Comment #14
spokjeComment #15
andypostyes, it's interesting why D10 used to allow 2.x
Comment #17
catchHmm. Wondering if we missed a 10.x commit somewhere, maybe a pre-9.4 dependency update that never had a 10.x version?
Either way, committed ab77cf9 and pushed to 9.5.x. Thanks!
Comment #18
catch