Problem/Motivation

Current run on PHP 8.2 beta1 at Drupal-CI produces tremendously huge logs (>2GB) but applying new attributes and remove them later in #3299855: [META] Get rid of #[\AllowDynamicProperties] attribute to give contrib to not abuse CI system logs while testing under 8.2 containers

Steps to reproduce

- attribute annotation + vfs fix https://dispatcher.drupalci.org/job/drupal_patches/139371/artifact/jenki...

Proposed resolution

5 classes needs this attribute and follow-ups to fix it properly

  1. core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php #3299857: [PP-1] Remove AllowDynamicProperties attribute from ConfigEntityBase
  2. core/lib/Drupal/Core/Extension/Extension.php #2024043: Add Module, Theme, Profile, and Extension value objects
  3. core/modules/views/src/Plugin/views/PluginBase.php #3299858: Remove AllowDynamicProperties attribute from views/PluginBase
  4. core/modules/views/src/Plugin/views/join/JoinPluginBase.php #3299859: Remove AllowDynamicProperties attribute from JoinPluginBase
  5. core/modules/views/src/ResultRow.php #3275858: View's ResultRow uses deprecated dynamic properties

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

no

CommentFileSizeAuthor
#2 3299853-2.patch2.19 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
3299853-2.patch2.19 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes
Status: Active » Needs review

Filed follow-up plan #3299855: [META] Get rid of #[\AllowDynamicProperties] attribute

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes
Related issues: +#3299858: Remove AllowDynamicProperties attribute from views/PluginBase, +#3299859: Remove AllowDynamicProperties attribute from JoinPluginBase, +#3299857: [PP-1] Remove AllowDynamicProperties attribute from ConfigEntityBase
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper at PreviousNext commented

+1 This seems like a sensible way to manage the transition away from dynamic properties.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Makes sense to me.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 0ca45bf on 10.0.x 
    Issue #3299853 by andypost, kim.pepper: Apply #[\AllowDynamicProperties...
  • catch committed db2e2d2 on 10.1.x
    Issue #3299853 by andypost, kim.pepper: Apply #[\AllowDynamicProperties...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 10.0.x-dev » 9.5.x-dev

Cherry-picked to 9.5.x too.