Remove AllowDynamicProperties attribute from JoinPluginBase

WIP

Thanks fixing my patch but looks you're added unrelated hunk

+++ b/core/tests/Drupal/FunctionalTests/EventSubscriber/MainContentViewSubscriberTest.php
@@ -0,0 +1,37 @@
+  public function testOnRedirectResponse(): void {
+    $this->drupalLogin($this->rootUser);
+    $this->drupalGet("/user?_wrapper_format=drupal_dialog");
+    $this->assertSession()->addressEquals('/user%3F_wrapper_format%3Ddrupal_dialog');

this test is not related here

Looks that's the only way to fix it with BC

But I'd like to change the property name to workspaceAdjasted so __get()/__set() could be needed

I find it ready now

random failure, needs review

@longwave Thank you! great idea to explore

Here's attempt to use internal property, the "query alter service" is created on every query alter, see workspaces_views_query_alter()

+++ b/core/modules/workspaces/src/ViewsQueryAlter.php
@@ -63,6 +63,13 @@ class ViewsQueryAlter implements ContainerInjectionInterface {
+   * An array of tables adjusted for workspace_association join.
...
+   * @var array
...
+  protected $adjustedTables = [];

It looks like backportable to 10.0.x

Good catch, looking at code it's not clear but views doing aliasing on every table so probably it would be ok but better to as @lendude

Other option could be using WeakMap to use join object as key so it should fix #15

Updated IS with last approach