[META] Fix PHP 8.2 dynamic property deprecations [#3275851]

Problem/Motivation

PHP 8.2 has what is likely to be a hugely disruptive deprecation of dynamic properties. This is used through out core and likely to cause numerous problems. Obviously deprecation don't _break_ sites but they will introduce warnings into dev environments that capture deprecation errors and block support for PHP 9 where they will be errors.

https://wiki.php.net/rfc/deprecate_dynamic_properties

Steps to reproduce

You can compile php 8.2 and run a site and see a number of deprecation notices. Late 2022 php 8.2 should be released and we will be seeing these in phpstan and during testbot runs.

Proposed resolution

List of must have issues to start pass tests

- #2839195: Add a method to access the original property

Done
- #3308744: Fix magic connection property access from \Drupal\Core\FileTransfer\FileTransfer::__get()
- #2531564: Fix leaky and brittle container serialization solution
- #3298731: Using ConstraintViolation::$arrayPropertyPath bugs on PHP 8.2
- #3274474: Fix 'Access to an undefined property' PHPStan L0 errors - to pass phpstan

And could have (could be extended)
- #3299855: [META] Get rid of #[\AllowDynamicProperties] attribute - tons of sub-issues to define all properties

Fixes will vary. For data objects we can either add #[AllowDynamicProperties] attribute to class or there is a simple-ish hack we can apply to support.


  /**
   * Raw row data.
   *
   * @var array
   */
  private array $data = [];

  /**
   * Implements the magic method for getting object properties.
   *
   * @param $name
   *   Property name.
   *
   * @return mixed
   *   The property value.
   */
  public function &__get($name) {
    return $this->data[$name];
  }

  /**
   * Implements the magic method to determines whether a property is set.
   *
   * @param $name
   *   Property name.
   *
   * @return bool
   *   True if property is set.
   */
  public function __isset($name) {
    return isset($this->data[$name]);
  }

  /**
   * Implements the magic method to set a property.
   *
   * @param $name
   *   Property name.
   * @param mixed $value
   *   The property value.
   */
  public function __set($name, $value) {
    $this->data[$name] = $value;
  }

  /**
   * Implements the magic method to unset a property.
   *
   * @param $name
   *   Property name.
   */
  public function __unset($name) {
    unset($this->data[$name]);
  }

Some things just don't work anymore #2531564: Fix leaky and brittle container serialization solution

Remaining tasks

Create tasks for issues.
Fix issues

User interface changes

n/a . This should only affect code interfaces.

API changes

Most changes should be to data objects or just missing properties so hopefully limited. I expect this will turn up some code smell that may result in deprecation though. Also we may find other hard changes like to our service container that require complicated fixes.

Data model changes

n/a

Release notes snippet

tbd

Comments

Comment #1

18 April 2022 at 19:19

neclimdul created an issue. See original summary.

Comment #2

neclimdul

He/Him

commented 18 April 2022 at 19:20

Apologies if this already exists or there's a PHP 8.2 issue that would be better for this but I didn't find it and wanted to start capturing obvious code that I run across that's going to be broken by this change.

Comment #3

neclimdul

He/Him

commented 18 April 2022 at 19:50

Issue summary:

View changes

Comment #4

mondrake

🇮🇹

commented 18 April 2022 at 20:34

Issue tags:		+PHP 8.2
Related issues:		+#3274474: Fix 'Access to an undefined property' PHPStan L0 errors

Very close to #3274474: Fix 'Access to an undefined property' PHPStan L0 errors

Comment #5

neclimdul

He/Him

commented 18 April 2022 at 20:44

Absolutely related, thanks. That'll fix a lot of accidental one's for sure. Was seeing quite a few of those for sure.

Comment #6

cilefen commented 18 April 2022 at 21:05

Title:

Fix dynamic propert deprecations.

» Fix dynamic property deprecations

Comment #7

gábor hojtsy

he/him

Hungarian

Hungary

commented 30 May 2022 at 19:19

Discussing this in the Drupal 10 readiness meeting. Should this be converted to a PHP 8.2 meta issue? (Since I don't think there is one yet)? @andypost suggested we take over this for a general PHP 8.2 META. Or do we expect more problems and this is a sub-set of the PHP 8.2 problems and should have a META above this?

Comment #8

xjm

she/her

English

commented 30 May 2022 at 19:20

I think this should be a child of the main PHP 8.2 meta, but also should be a meta in its own right.

Title:	Fix dynamic property deprecations	» [META] Fix dynamic property deprecations
Parent issue:		» #3118149: [meta] Requirements for tagging Drupal 10.0.0-beta1

[META] Fix PHP 8.2 dynamic property deprecations

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Parent issue

Child issues

Related issues

Referenced by