Problem/Motivation

The #[AllowDynamicProperties] been merged into 1.8.1 release via https://github.com/phpstan/phpstan-src/pull/1478

Steps to reproduce

See #3275858-4: View's ResultRow uses deprecated dynamic properties testing results

Proposed resolution

Upgrade to https://github.com/phpstan/phpstan/releases/tag/1.8.1 to allow testing PHP 8.2 attribute which required to fix compatibility

Remaining tasks

- create patch and review
- commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

no

CommentFileSizeAuthor
#6 3293933-6.patch2.34 KBandypost
#2 3293933-2.patch3.76 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3293933-2.patch3.76 KB

initial attempt

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Upgrade phpstan to 1.8 » Upgrade phpstan to 1.8.0
mondrake’s picture

mondrake
Location 🇮🇹
commented

dupe of #3282315: Update phpstan/phpstan and mglaman/phpstan-drupal to latest versions

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Closed (duplicate)
andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Upgrade phpstan to 1.8.0 » Upgrade phpstan to 1.8.1
Issue summary: View changes
Status: Closed (duplicate) » Needs review
StatusFileSize
new 3293933-6.patch2.34 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Upgrade phpstan to 1.8.1 » Upgrade phpstan/phpstan to 1.8.1
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +blocker
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

LGTM

  • catch committed 0a4dcf7 on 10.0.x 
    Issue #3293933 by andypost: Upgrade phpstan/phpstan to 1.8.1

(cherry...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

  • catch committed 7749fc0 on 10.1.x 
    Issue #3293933 by andypost: Upgrade phpstan/phpstan to 1.8.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.