Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Accessing (as admin) a non-existing event details at admin/reports/dblog/event/ returns an empty page, it should return the 404 error page.
Proposed resolution
Throw NotFoundHttpException at the dblog controller for non-existing events.
Remaining tasks
Review path.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
TBD.
Comment | File | Size | Author |
---|---|---|---|
#9 | 3101108-9.patch | 5.35 KB | Krzysztof Domański |
#9 | interdiff-6-9.txt | 849 bytes | Krzysztof Domański |
#7 | after-patch.png | 113.11 KB | Hardik_Patel_12 |
#7 | before-patch.png | 96.64 KB | Hardik_Patel_12 |
#4 | drupal_db_log.JPG | 19.55 KB | Krzysztof Domański |
Comments
Comment #2
manuel.adanComment #4
Krzysztof DomańskiFixed coding standards and re-rolled. Tested manually. RTBC +1.
Comment #5
dagmarThanks for working on this. I see the opportunity to simplify the nesting of the
eventDetails
method if we check first if the log record exists and throw the exception early. Theelse
there is really far away from theif
so is hard to read. Also this approach simplifies the entire method because removes a lot of indentation.Comment #6
Krzysztof DomańskiComment #7
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 commentedpatch at #6 look good to me and it is working properly.
Comment #8
catchI think this should be non-random - can we just make it 999999 or something?
Comment #9
Krzysztof DomańskiComment #10
dagmarThanks @Krzysztof Domański
Comment #13
daffie CreditAttribution: daffie commentedSo the issue is fixed then.
Comment #14
catchCommitted 08582f7 and pushed to 9.0.x. Backported to 8.9.x Thanks!