Convert system functional tests to phpunit
Scope:
./System/AccessDeniedTest.php
./System/AdminTest.php
./System/CronRunTest.php
./System/DefaultMobileMetaTagsTest.php
./System/ErrorHandlerTest.php - see #2984072: System: Convert ErrorHandlerTest to phpunit
./System/FloodTest.php
./System/FrontPageTest.php
./System/HtaccessTest.php
./System/PageNotFoundTest.php
./System/PageTitleTest.php
./System/ResponseGeneratorTest.php - see #2927766: Update ResponseGeneratorTest to use the BrowserTestBase base class instead of the deprecated RESTTestBase
./System/ShutdownFunctionsTest.php
./System/SiteMaintenanceTest.php
./System/SystemConfigFormTestBase.php - see #2941494: Deprecate SystemConfigFormTestBase and create kernel test version
./System/ThemeTest.php
./System/TokenReplaceWebTest.php
./System/UncaughtExceptionTest.php - see #2863262: Bootstrap: Convert system functional tests to phpunit
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff-2982150-9-12.txt | 1.12 KB | ApacheEx |
#12 | 2982150-12.patch | 25.23 KB | ApacheEx |
Comments
Comment #2
LendudeComment #3
LendudeComment #4
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedFirst try without
ErrorHandlerTest
andUncaughtExceptionTest
which have some methods from simpletest module.all these methods (more/less) are working with assertions in simpletest table - need to think how to deal with it, what's about followup?
p.s. I'm trying to do as minimal as possible changes to make tests passed.
Comment #6
Lendude@ApacheEx thanks!
UncaughtExceptionTest is part of another conversion #2863262: Bootstrap: Convert system functional tests to phpunit, so +1 to leaving that out here (it's also very hard :)
Comment #7
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedHere is the second try :)
Still without ErrorHandlerTest. But let's check how it's going with other tests.
Comment #9
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentednow it should pass (yn)
Comment #10
Lendude@ApacheEx very nice minimal conversion. Thank you! I went through it and everything looks good to me.
awesome! great conversion to a KernelTest, gets rid of the $request injection nicely.
So this just leaves
ErrorHandlerTest
, which probably needs a follow up because that isn't straight forward, andUncaughtExceptionTest
which has a follow up.Comment #11
alexpottLet's add an install hook for the module that does this:
This is related to #2783791: Module install doesn't invalidate render cache
Comment #12
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Internetdevels, Drupal Ukraine Community commentedThanks for review and feedback, all make sense for me.
Here is updated patch.
Comment #13
Lendude@ApacheEx, thanks for that! Feedback has been addressed, back to RTBC.
Comment #14
alexpottCommitted 013d70a and pushed to 8.6.x. Thanks!
Comment #16
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedThanks a lot. I've added a followup for ErrorHandlerTest.