Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In working on #2893804: Remove rest.module BC layers, it became clear that \Drupal\system\Tests\System\ResponseGeneratorTest was still using the deprecated RESTTestBase base test class. In fact, this issue blocks that issue.
We could use ResourceTestBase, but that's more than overkill here. The successor to WebTestBase, BrowserTestBase, is more than capable enough for our needs!
Proposed resolution
Update DbLogResourceTest.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2927766-2.patch | 2.47 KB | Wim Leers |
Comments
Comment #2
Wim LeersComment #3
Wim LeersComment #4
dawehnerSeems fine.
@Wim Leers
Just a general note: These issues seems to be totally mid-level issues, as in, there are at least a ton of other people out there who could work on those. Just tag for example issues related with phpunit conversions as "phpunit initiative" and you'll get someone to do it.
Comment #5
Wim Leers@dawehner: I only realized that after the fact … I was first removing this test altogether, and moving its assertions elsewhere. By the time I realized I should just convert the existing test to BrowserTestBase, I'd already done exactly that. I did create #2927768: Update RestRegisterUserTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase with that exact purpose though, and even tweeted about it! I also just tagged it :)
Comment #7
xjmCommitted and pushed to 8.5.x. Thanks!
Comment #8
dawehnerYeah no worries, I just hope you take that into account in general.
Comment #9
Wim LeersOne less blocker for #2927766 now: #2927766: Update ResponseGeneratorTest to use the BrowserTestBase base class instead of the deprecated RESTTestBase.