Problem/Motivation

Tasks to do: Create an issue per group listed below. Try to work on one of those conversions.

Groups

Ajax

#2862510: Convert system/tests/src/Ajax to JavascriptTestBase
./Ajax/AjaxFormCacheTest.php
./Ajax/AjaxFormPageCacheTest.php
./Ajax/AjaxInGroupTest.php
./Ajax/AjaxTestBase.php
./Ajax/CommandsTest.php
./Ajax/DialogTest.php
./Ajax/ElementValidationTest.php
./Ajax/FormValuesTest.php
./Ajax/FrameworkTest.php
./Ajax/MultiFormTest.php

Batch

#2862885: Batch: Convert system functional tests to phpunit
./Batch/PageTest.php
./Batch/ProcessingTest.php

Bootstrap/error handling

#2863262: Bootstrap: Convert system functional tests to phpunit
./Bootstrap/ErrorContainer.php
./Bootstrap/ExceptionContainer.php

Cache

#2863318: Cache: Convert system functional tests to phpunit

./Cache/AssertPageCacheContextsAndTagsTrait.php
./Cache/CacheTestBase.php
./Cache/GenericCacheBackendUnitTestBase.php
./Cache/PageCacheTagsTestBase.php
./Cache/SessionExistsCacheContextTest.php

Common ¯\_(ツ)_/¯

#2863382: Common: Convert system functional tests to phpunit
./Common/AddFeedTest.php
./Common/AlterTest.php
./Common/EarlyRenderingControllerTest.php
./Common/FormatDateTest.php
./Common/NoJavaScriptAnonymousTest.php
./Common/RenderWebTest.php
./Common/SimpleTestErrorCollectorTest.php
./Common/UrlTest.php

Database

#2872151: Database/DrupalKernel: Convert system functional tests to PHPUnit
./Database/DatabaseWebTestBase.php
./Database/FakeRecord.php
./Database/SelectPagerDefaultTest.php
./Database/SelectTableSortDefaultTest.php
./Database/TemporaryQueryTest.php
./DrupalKernel/ContainerRebuildWebTest.php

Entity

#2946419: Module: Convert system functional tests to phpunit
./Entity/EntityCacheTagsTestBase.php
./Entity/EntityDefinitionTestTrait.php
./Entity/EntityFormTest.php
./Entity/EntityTranslationFormTest.php
./Entity/EntityUnitTestBase.php
./Entity/EntityWithUriCacheTagsTestBase.php
./Entity/Update/LangcodeToAsciiUpdateFilledTest.php
./Entity/Update/LangcodeToAsciiUpdateTest.php
./Entity/Update/MoveRevisionMetadataFieldsUpdateTest.php
./Entity/Update/SqlContentEntityStorageSchemaIndexFilledTest.php
./Entity/Update/SqlContentEntityStorageSchemaIndexTest.php
./Entity/Update/UpdateApiEntityDefinitionUpdateTest.php

Either in scope for Entity or as a followup for Entity:
\Drupal\comment\TestsCommentCacheTagsTest

Form

./Condition/ConditionFormTest.php
./Form/AlterTest.php
./Form/ArbitraryRebuildTest.php
./Form/CheckboxTest.php
./Form/ConfirmFormTest.php
./Form/ElementsLabelsTest.php
./Form/ElementsTableSelectTest.php
./Form/ElementsVerticalTabsTest.php
./Form/ElementTest.php
./Form/EmailTest.php
./Form/FormStoragePageCacheTest.php
./Form/FormTest.php
./Form/LanguageSelectElementTest.php
./Form/ProgrammaticTest.php
./Form/RebuildTest.php
./Form/ResponseTest.php
./Form/StateValuesCleanAdvancedTest.php
./Form/StateValuesCleanTest.php
./Form/StorageTest.php
./Form/StubForm.php
./Form/SystemConfigFormTest.php
./Form/TriggeringElementTest.php
./Form/UrlTest.php
./Form/ValidationTest.php

Image

#2862641: Image: Convert system functional tests to phpunit

./Image/ToolkitSetupFormTest.php
./Image/ToolkitTest.php
./Image/ToolkitTestBase.php

Installer (Hard)

#2907728: Installer: Convert system functional tests to phpunit
./Installer/ConfigAfterInstallerTestBase.php
./Installer/DistributionProfileExistingSettingsTest.php
./Installer/DistributionProfileTest.php
./Installer/DistributionProfileTranslationQueryTest.php
./Installer/DistributionProfileTranslationTest.php
./Installer/InstallerConfigDirectorySetNoDirectoryErrorTest.php
./Installer/InstallerConfigDirectorySetNoDirectoryTest.php
./Installer/InstallerDatabaseErrorMessagesTest.php
./Installer/InstallerEmptySettingsTest.php
./Installer/InstallerExistingConfigDirectoryTest.php
./Installer/InstallerExistingDatabaseSettingsTest.php
./Installer/InstallerExistingInstallationTest.php
./Installer/InstallerExistingSettingsMismatchProfileBrokenTest.php
./Installer/InstallerExistingSettingsMismatchProfileTest.php
./Installer/InstallerExistingSettingsNoProfileTest.php
./Installer/InstallerExistingSettingsTest.php
./Installer/InstallerLanguageDirectionTest.php
./Installer/InstallerLanguagePageTest.php
./Installer/InstallerTest.php
./Installer/InstallerTranslationMultipleLanguageForeignTest.php
./Installer/InstallerTranslationMultipleLanguageKeepEnglishTest.php
./Installer/InstallerTranslationMultipleLanguageTest.php
./Installer/InstallerTranslationQueryTest.php
./Installer/InstallerTranslationTest.php
./Installer/MinimalInstallerTest.php
./Installer/MultipleDistributionsProfileTest.php
./Installer/SingleVisibleProfileTest.php
./Installer/SiteNameTest.php
./Installer/StandardInstallerTest.php

Menu

#2887099: Menu: convert system functional tests to PHPUnit
./Menu/AssertBreadcrumbTrait.php
./Menu/AssertMenuActiveTrailTrait.php
./Menu/BreadcrumbTest.php
./Menu/LocalActionTest.php
./Menu/LocalTasksTest.php
./Menu/MenuRouterTest.php
./Menu/MenuTestBase.php

Module

#2930072: Module: Convert system functional tests to phpunit
./Module/DependencyTest.php
./Module/HookRequirementsTest.php
./Module/InstallUninstallTest.php
./Module/ModuleTestBase.php
./Module/PrepareUninstallTest.php
./Module/RequiredTest.php
./Module/VersionTest.php

Page/Routing/Render

./Page/DefaultMetatagsTest.php
./Pager/PagerTest.php
./Path/UrlAliasFixtures.php
./Render/HtmlResponseAttachmentsTest.php
./Render/UrlBubbleableMetadataBubblingTest.php
./Routing/DestinationTest.php
./Routing/MockAliasManager.php
./Routing/MockRouteProvider.php
./Routing/RouterTest.php
./Session/SessionAuthenticationTest.php
./Session/SessionHttpsTest.php
./Session/SessionTest.php
./Session/StackSessionHandlerIntegrationTest.php

System

./System/AccessDeniedTest.php
./System/AdminTest.php
./System/CronRunTest.php
./System/DefaultMobileMetaTagsTest.php
./System/ErrorHandlerTest.php
./System/FloodTest.php
./System/FrontPageTest.php
./System/HtaccessTest.php
./System/PageNotFoundTest.php
./System/PageTitleTest.php
./System/ResponseGeneratorTest.php
./System/ShutdownFunctionsTest.php
./System/SiteMaintenanceTest.php
./System/SystemConfigFormTestBase.php
./System/ThemeTest.php
./System/TokenReplaceWebTest.php
./System/UncaughtExceptionTest.php

Theme

#2863429: Theme: Convert system functional tests to phpunit
./Theme/EngineTwigTest.php
./Theme/EntityFilteringThemeTest.php
./Theme/FunctionsTest.php
./Theme/HtmlAttributesTest.php
./Theme/ThemeSuggestionsAlterTest.php
./Theme/ThemeTest.php
./Theme/TwigDebugMarkupTest.php
./Theme/TwigFilterTest.php
./Theme/TwigNamespaceTest.php
./Theme/TwigRawTest.php
./Theme/TwigTransTest.php

Update (hard)

#2870009: Update: Convert system functional tests to phpunit

./Update/AutomatedCronUpdateWithAutomatedCronTest.php
./Update/AutomatedCronUpdateWithoutAutomatedCronTest.php
./Update/ConfigOverridesUpdateTest.php
./Update/DbUpdatesTrait.php
./Update/DependencyHookInvocationTest.php
./Update/DependencyMissingTest.php
./Update/DependencyOrderingTest.php
./Update/FieldSchemaDataUninstallUpdateTest.php
./Update/FilterHtmlUpdateTest.php
./Update/InstallProfileSystemInstall8300Test.php
./Update/InvalidUpdateHookTest.php
./Update/LocalActionsAndTasksConvertedIntoBlocksUpdateTest.php
./Update/MenuTreeSerializationTitleFilledTest.php
./Update/MenuTreeSerializationTitleTest.php
./Update/PageTitleConvertedIntoBlockUpdateTest.php
./Update/RecalculatedDependencyTest.php
./Update/RouterIndexOptimizationFilledTest.php
./Update/RouterIndexOptimizationTest.php
./Update/SevenSecondaryLocalTasksConvertedIntoBlockUpdateTest.php
./Update/SiteBrandingConvertedIntoBlockUpdateTest.php
./Update/StableBaseThemeUpdateTest.php
./Update/UpdateEntityDisplayTest.php
./Update/UpdatePathRC1TestBaseFilledTest.php
./Update/UpdatePathRC1TestBaseTest.php
./Update/UpdatePathTestBase.php
./Update/UpdatePathTestBaseFilledTest.php
./Update/UpdatePathTestBaseTest.php
./Update/UpdatePathTestJavaScriptTest.php
./Update/UpdatePathWithBrokenRoutingFilledTest.php
./Update/UpdatePathWithBrokenRoutingTest.php
./Update/UpdatePostUpdateFailingTest.php
./Update/UpdatePostUpdateTest.php
./Update/UpdateSchemaTest.php
./Update/UpdateScriptTest.php
./Update/UpdatesWith7xTest.php

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

dawehner created an issue. See original summary.

dawehner’s picture

Issue summary: View changes
klausi’s picture

Title: Convert system functiona tests to phpunit » Convert system functional tests to phpunit
dawehner’s picture

Issue summary: View changes
martin107’s picture

I'm going to start converting the image group stuff here...

martin107’s picture

Splitting off batch stuff.

Jo Fitzgerald’s picture

Jo Fitzgerald’s picture

Jo Fitzgerald’s picture

jhedstrom’s picture

Added an issue for the form tests.

martin107’s picture

Issue summary: View changes

Added new sub issue AJAX

martin107’s picture

Issue summary: View changes

ajax issue already existed -- tidying up issue summary.

dawehner’s picture

Issue summary: View changes
phenaproxima’s picture

michielnugter’s picture

Issue summary: View changes
martin107’s picture

Status: Active » Postponed
Related issues: +#2869825: Leverage JS for JS testing (using nightwatch)

I am linking to a speculative issue - which would invalidate all the work queued here.

For me the killer argument is:-

If we want to welcome new JS developers into the community.

It is a turn off to force them to learn php.

So I think we should postpone this until the path ahead becomes clear.

dawehner’s picture

Status: Postponed » Active

@martin107 I agree with you. Can you please comment on the nightwatch issue about that?

I think though there are A LOT of issues in this plan which are independent from JS, if not most of them. There is no reason to block work based upon that.

Lendude’s picture

Issue summary: View changes

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

Issue summary: View changes
dawehner’s picture

Issue summary: View changes
dawehner’s picture

Issue summary: View changes
dawehner’s picture

Issue summary: View changes
Lendude’s picture

vaplas’s picture

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

vaplas’s picture