Comment update core 8.4

@Musa.thomas Would you please add more of the steps to reproduce this?

I too am experiencing this issue.

This site is a dev sandbox, the only installed contrib module is "examples", no contrib theme is installed. PHP Version 7.0.22-0ubuntu0.16.04.1 and MySQL Server version: 5.7.19-0ubuntu0.16.04.1

Using Composer I successfully updated Drupal Core (from 8.37) and Drush (from 8.x) first.

Drush Commandline Tool 9.0.0-beta7
Drupal Version 8.4.0

I then executed the database updates, no errors surfaced but it didn't look complete:

admin@osboxes /var/www/html/drupal8.dev $ drush updb
The following updates are pending:

comment module : 
Enable the comment admin view.

dblog module : 
Replace 'Recent log messages' with a view.

field module : 
Remove the stale 'handler_submit' setting for entity_reference fields.

node module : 
Load all form displays for nodes, add status with these settings, save.

system module : 
Clear caches to ensure Classy's message library is always added.
Force field type plugin definitions to be cleared.   @see https:www.drupal.orgnode2403703

views module : 
Fix table names for revision metadata fields.

 Do you wish to run all pending updates? (yes/no) [yes]:
 > 

 [ok] Post updating comment
 [success] Cache rebuild complete.
 [success] Finished performing updates.

admin@osboxes /var/www/html/drupal8.dev $ drush cr
 [success] Cache rebuild complete.

My /admin/reports/status page reports an error:

Errors found
DATABASE UPDATES Out of date
Some modules have database schema updates to install. You should run the database update script immediately.

When I execute the update script via the browser I can see the exception on the /update.php/results page

The following updates returned messages:
comment module
Update enable_comment_admin_view
Failed: Drupal\Core\Entity\EntityStorageException: 'action' entity with ID 'comment_delete_action' already exists. in Drupal\Core\Entity\EntityStorageBase->doPreSave() (line 425 of /var/www/html/drupal8.dev/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php).

OK so I see that this is likely due to an 8.4 dependency issue that is being discussed in various places.

https://www.drupal.org/node/2898119
https://www.drupal.org/node/2914356

Some have recommended adding platform min version to the composer.json file like this...

config": {
      "sort-packages": true,
      "platform": {"php": "5.6"}
    },

... so I did and tried another composer update...

admin@osboxes /var/www/html/drupal8.dev $ composer update drupal/core --with-dependencies
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Updating doctrine/inflector (v1.2.0 => v1.1.0): Downloading (100%)         
Writing lock file

... but can't uninstall the comment module to get past the exception during db update.

From what I'm reading the recommendation is to upgrade to PHP 7.1.

So I got around the db update error with some manual SQL.

DELETE FROM `config` WHERE name = "system.action.comment_delete_action;"
DELETE FROM `config` WHERE name = "views.view.comment";
TRUNCATE TABLE `cache_config`;

Cleared cache and ran update.php again, this time without any problems and the status report shows no errors.

I ran into the problem same with #8

Pushing new patch that includes fix for comment

Fixing typo

The test results failed

.

Do we need to add a test here? It seems obvious to me that we should check if the config already exists before creating it again. I've re-queued tests in hopes the earlier failures were just intermittent testbot issues.

Thank you zenlan - i don't know how 'correct' your approach is but it worked for me and got me past repeated problems running drush updb and enabled it to complete. The one tweak was a mis-ordered semi-colon

DELETE FROM `config` WHERE name = "system.action.comment_delete_action";
DELETE FROM `config` WHERE name = "views.view.comment";
TRUNCATE TABLE `cache_config`;

Going to go out on a limb here and say an test isn't needed. And the patch obviously fixes the update path.

8.4.x is into 'criticals only' mode, so this needs to go into 8.5.x

We have an existing upgrade path test for this, lets expand on it for this scenario.

Dear zenlan,

Your approached work after running the SQL query.

But the question is why this error occurring ?

Regards,
Nikunj Patel

This is how to run the commands via drush:

drush sql-query "DELETE FROM config WHERE name ='system.action.comment_delete_action';"
drush sql-query "DELETE FROM config WHERE name ='views.view.comment';"
drush sql-query "TRUNCATE TABLE cache_config;"

#25 works for me.

#25 is also working for me Thanks

#25 worked for me

Running the drush commands #25 and then run the update again worked for me too.

Got this same error (PHP 7.2, Drupal 8.6.2) and #10 did the trick for me. Thanks!

Patch in #3 worked for me. Thanks.

Is anyone experiencing this problem? If so, add a comment.

There have been no reports of this problem for 4 years or that it is blocking an upgrade. For anyone encounetring this the workarounds are listed in the Issue Summary.

Therefore, closing as outdated. If you are encountering this problem open a new issue and refer to this one.

Thanks!