If you add a view filter whose description includes a '>' or '<' character, the character appears as encoded html. The filter in the example below should say Content: Event date (>= today) but instead is rendered as Content: Event date (&gt;= today).

CommentFileSizeAuthor
#14 Screenshot_2021-11-09 Atest2 (Content) dev0-web.png1.97 KBquietone
#13 2816973-before_patch.png28.29 KBabhijith s
#13 2816973-after_patch.png27.08 KBabhijith s
#13 2816973-13.patch851 bytesabhijith s
#4 views_ui_double_escaping-2816973-0.patch757 bytesstaalex
Screenshot 2016-10-12 02.24.36.png15.61 KBamklose

Comments

amklose created an issue. See original summary.

staalex’s picture

staalex commented
Assigned: Unassigned » staalex
staalex’s picture

staalex commented
Component: views.module » views_ui.module
staalex’s picture

staalex commented
Status: Active » Needs review
StatusFileSize
new views_ui_double_escaping-2816973-0.patch757 bytes
staalex’s picture

staalex commented
Assigned: staalex » Unassigned

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

abhijith s’s picture

abhijith s commented

Patch #4 can't be applied on 8.9.x.

Checking patch core/modules/views_ui/src/ViewEditForm.php...
error: while searching for:
      }

      $description = Xss::filterAdmin($handler->adminSummary());
      $link_text = $field_name . (empty($description) ? '' : " ($description)");
      $link_attributes = array('class' => array('views-ajax-link'));
      if (!empty($field['exclude'])) {

error: patch failed: core/modules/views_ui/src/ViewEditForm.php:1057
error: core/modules/views_ui/src/ViewEditForm.php: patch does not apply
abhijith s’s picture

abhijith s commented
StatusFileSize
new 2816973-13.patch851 bytes
new 2816973-after_patch.png27.08 KB
new 2816973-before_patch.png28.29 KB

Adding new patch.Please review it.

Before patch:
before

After patch:
after

quietone’s picture

quietone commented
Version: 8.9.x-dev » 9.3.x-dev
Issue summary: View changes
Status: Needs review » Closed (cannot reproduce)
Issue tags: +Bug Smash Initiative
StatusFileSize
new Screenshot_2021-11-09 Atest2 (Content) dev0-web.png1.97 KB

@amklose, Thank you for reporting this problem. We rely on issue reports like this to improve Drupal core.

I tested this on 9.3.x and was not able to reproduce this error.

Therefore, closing as cannot reproduce. If you are experiencing this problem reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue (starting from "Install Drupal core").

Thanks!