This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).

We need to test:
Default site mail-from setting.

CommentFileSizeAuthor
#17 tests_v3.patch2.35 KBp.brouwers
#15 tests_v2.patch2.38 KBp.brouwers
#3 tests.patch2.58 KBp.brouwers

Comments

p.brouwers’s picture

p.brouwers commented
Assigned: Unassigned » p.brouwers

I'm interested in doing these tests.

catch’s picture

catch
he/him
Primary language English
commented
Title: Tests needed: mail.inc » TestingParty08: default site mail settings
Assigned: p.brouwers » Unassigned

Opening up for the testing party.

p.brouwers’s picture

p.brouwers commented
StatusFileSize
new tests.patch2.58 KB

I was busy writing the 4 mail tests in one .test file, but I see you've divided it into 4 different tests.

I've cleanup the files and left only this test in it.
I named it 'mail', I hope that's correct.

Should the other mail tests be in another file?

catch’s picture

catch
he/him
Primary language English
commented
Title: TestingParty08: default site mail settings » Tests needed mail.inc
Status: Active » Needs review

Hi p.brouwers The split is pretty arbitrary due to the testing party at Drupalcon next week. If you've got a full test for this, please post it here and we can close out the other issues.

p.brouwers’s picture

p.brouwers commented

ah ok.
I still need to write a test for CustomBackends. I'm not really familiar with that, so I don't know how long that'll take.

robloach’s picture

robloach
he/him
commented

#331180: fix pluggable smtp/mail framework introduces a nice pluggable mail system as well as a test for it, should this issue be merged in with it?

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou commented
Status: Needs work » Needs review

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

We no longer have phpdoc for setUp(), getInfo() or tearDown()
http://drupal.org/node/325974

robloach’s picture

robloach
he/him
commented
Status: Needs work » Postponed

Postponed until #331180: fix pluggable smtp/mail framework is in.

jax’s picture

jax commented
Component: tests » base system

Referenced issue was committed. A mail.test file has already been created. I'm not sure if this is still relevant. Can someone confirm this can be closed?

Stevel’s picture

Stevel commented
Priority: Critical » Normal
Status: Postponed » Needs work

The tests seem complementary, so these tests can be added, but should probably be integrated in the existing mail.test file.

Chethan K’s picture

Chethan K commented
Status: Needs work » Needs review

#3: tests.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, tests.patch, failed testing.

p.brouwers’s picture

p.brouwers commented
Status: Needs work » Needs review
StatusFileSize
new tests_v2.patch2.38 KB

updated patch for latest version of D7

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work 
+    $this->assertIdentical($default_from, $message['headers']['From'], t('testing equality of default-from setting'));
+  }
+}
\ No newline at end of file

Add a newline to remove that message

p.brouwers’s picture

p.brouwers commented
Status: Needs work » Needs review
StatusFileSize
new tests_v3.patch2.35 KB

added the newline

thedavidmeister’s picture

thedavidmeister commented
Version: 7.x-dev » 8.0.x-dev
Issue summary: View changes
Status: Needs review » Needs work

Looks like this should be done for d8 now.

I imagine it would live in Drupal\system\Tests\Mail\MailTest and be relatively easy to write in context of what's in that file.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Status: Needs work » Closed (duplicate)
Issue tags: +Bug Smash Initiative
Related issues: +#3028712: Convert system MailTest into a Kernel test. Break its simpletest dependency, +#3098058: [D7] Use site name in From: header for system e-mails

This was fixed for D7 in #3098058: [D7] Use site name in From: header for system e-mails and for D8.8 in #3028712: Convert system MailTest into a Kernel test. Break its simpletest dependency. I guess that makes this a duplicate, although it predates those issues.

Closing as a duplicate.