Follow-up to #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class
Problem/Motivation
According to #2346261: Deprecate entity_create() in favor of a <EntityType>::create($values) or \Drupal::entityManager()->getStorage($entity_type)->create($values), entity_create() function is going to be deprecated so we shouldn't use it anymore. When the entity type is known we should directly call <EntityType>::create()
. What to do when the entity type is not known or is variable is upon discussions.
Beta phase evaluation
Issue category | Task |
---|---|
Issue priority | Normal because it's just about code cleanup and good practices |
Prioritized changes | The main goal of this issue is DX, performance and removing code already deprecated for 8.0.0. (Direct calls to EntityType::create are better than generic calls to entity_create for readability) |
Disruption | This change is not disruptive at all as it only replaces deprecated functions call by their exact equivalent. |
Proposed resolution
Replace the deprecated call to entity_create()
by a proper call to <EntityType>::create()
.
Before:
entity_create('field_config', $field_values)->save();
After:
use Drupal\field\Entity\FieldConfig;
FieldConfig::create($field_values)->save();
Remaining tasks
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Create a patch | Instructions | Done | |
Manually test the patch | Novice | Instructions | |
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#14 | field_storage_config-2641586-14.patch | 104.29 KB | marvin_B8 |
Comments
Comment #2
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #4
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedFixed class aliasing
Comment #5
swentel CreditAttribution: swentel commentedDoesn't apply anymore (probably after #2604220: PHP notice for single value image field configured with a default image (no image present) and a hidden label), should be easy to fix.
Comment #6
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedrerolled
Comment #8
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedThere was an error at the last patch.
Comment #9
Wim LeersApplied, searched for
entity_create('field_storage_config'
and<code>entity_create("field_storage_config"
. Zero matches after this patch is applied.Hence RTBC.
Comment #11
Wim LeersSeems like something changed in the mean time:
Comment #12
BerdirComment #14
marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commentedreroll #8
Comment #15
marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commentedComment #17
marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commentedComment #18
Wim LeersHurray, green again!
Comment #19
catchCommitted/pushed to 8.1.x, thanks!
Comment #22
savkaviktor16@gmail.com CreditAttribution: savkaviktor16@gmail.com at Skilld commented