Deprecate dead code locale_translation_manual_status()

Moving to 8.4.x because removing a function might be disruptive.

Patch no longer applies.

Re-rolled.

Looks good. Thanks.

#1978928: Convert locale_translation_manual_status to a Controller I am confused.

Oh it looks like this issue added the function back. I have not yet read about why.

Talked to the release managers, and they said that we shouldn't remove these type of functions because they're not explicitly marked @internal, and therefore we have no idea if some esoteric contrib modules might be relying on then, and therefore it's safer to merely deprecate them, so we can find them again and ditch them for good in Drupal 9.

Here's the documentation (I think) on how to do so: https://www.drupal.org/core/deprecation

Yeah, to add to #11, it is extremely unlikely that anyone would actually use this, especially given what it actually does (eek!). But since it also costs us nothing to leave it there until the mass removal of @deprecated for D9, it's better to just be in the habit of marking things deprecated for later removal since we don't always think of everything when evaluating potential disruptions, and also to just set a good model for contributors.

Oh, and I should note that @webchick, @cilefen, and I discussed whether this should be treated as a controller since it was a page callback. But since it is not a controller and since no route uses it, it's technically just a weird global function. :)

Looks like we just missed it in #1978916: Convert locale_translate_page to a Controller there is a comment on #67 about it but not addressed anywhere after. Marking as Novice for depreciation task.

Added the deprecation notice.Should @see and @trigger_error be added??

Yes. Here's the deprecation documentation: https://www.drupal.org/core/deprecation#how-function

Patch still applies.

+ * @deprecated in Drupal 8.0.0 and will be removed before 9.0.0.

Should now be "8.5.0"

Updated depricated version number from 8.0.0 to 8.5.0 per #21.

Thanks for changing the version number.

1. +++ b/core/modules/locale/locale.pages.inc
   @@ -13,9 +13,12 @@
   + * @deprecated in Drupal 8.5.0 and will be removed before 9.0.0.
   + * @see https://www.drupal.org/node/2551259
   

   Needs a blank line before @see. See https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...

2. +++ b/core/modules/locale/locale.pages.inc
   @@ -13,9 +13,12 @@
   +  @trigger_error('locale_translation_manual_status() is deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0. Use locale_menu(). See https://www.drupal.org/node/2551259.', E_USER_DEPRECATED);
   

   locale_menu() no longer exist and should therefore not be given as replacement. I advise not to give any replacement here because the is none.

Addressed comments in #24.

Interdiff looks good, patch looks good.
Issue summary checked Ok.

Thanks for working on this.

This is linking to this issue's NID. It should be linking the relevant change record instead. We also need to tell people what to do instead. If there is no direct replacement, we should say that, and say why (or what code that previously used this function should do instead).

Thanks!

Adding tasks to the issue summary.

Drafted change record: https://www.drupal.org/node/2931188

Updated @see to the CR.

Added a test to make sure the deprecation works since that's our policy: https://www.drupal.org/core/deprecation

1) Drupal\Tests\locale\Kernel\LocaleDeprecationsTest::testLocaleTranslationManualStatusDeprecation
@covers global method does not exist locale_translation_manual_status:

Oh yeah.... For kernel tests, the test listener runs in a different process than the test itself, so loaded include files aren't available to DrupalStandardsListener after the test finishes. Thus it can't verify that an extension's global function is available.

I guess we'll have to forgo the coveted declared coverage stats for this deprecated method.

1) Drupal\Tests\rest\Functional\EntityResource\View\ViewJsonCookieTest::testPatch
Exception: Warning: apcu_store(): Unable to allocate memory for pool.
Symfony\Component\ClassLoader\ApcClassLoader->findFile()() (Line: 128)

Pretty sure that's unrelated.

Previous test fail unrelated.

Looks solid.

Committed 0308764 and pushed to 8.5.x. Thanks!

publish the change record