The file hiddeninput.exe located in vendor/symfony/console/Resources/bin is not valid. Executing the command on a Windows system (cygwin) results in this:
hw@hwlaptop:/cygdrive/d/Internet/d8/d8task/core/vendor/symfony/console/Resource
s/bin$ ./hiddeninput.exe
bash: ./hiddeninput.exe: cannot execute binary file: Exec format error
In Windows command prompt, this is the error:
D:\Internet\d8\d8task\core\vendor\symfony\console\Resources\bin>hiddeninput.exe
This version of D:\Internet\d8\d8task\core\vendor\symfony\console\Resources\bin\
hiddeninput.exe is not compatible with the version of Windows you're running. Ch
eck your computer's system information and then contact the software publisher.
The file's actual history can be seen here. As seen, the file has not been touched since 2012, but we have had to update it in #2498515-12: Update additional Symfony Components to 2.7.0 and now #2504967: Upgrade to Symfony 2.7.1. This was mainly because of an issue in git configuration which was perceived fixed but later cropped up in the latter issue.
The exe file contains CRLF characters and PIFR rejects patches with CR characters. This was seen in #2504967: Upgrade to Symfony 2.7.1 in patches in #4, #7, #9, and #11. I attempted to explain this in #2504967-11: Upgrade to Symfony 2.7.1.
Since that issue is a critical, I am creating this followup to fix hiddeninput.exe to actual/working version.
Put the correct hiddeninput.exe.
- Write a patch
- Decide if we should wait for it to pass on PIFR OR wait for the bug to be resolved in PIFR.
- Review
- Commit
None
None
None
| Issue category | Task because it involves changing a piece of code to ensure correctness, but doesn't affect regular operation. |
|---|---|
| Issue priority | Major because ... Critical/Not critical because ... |
| Prioritized changes | The main goal of this issue is follow-up from a recent critical. |
| Disruption | Not Disruptive |
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | fix_hiddeninput_exe_in-2531796-1.patch | 14.95 KB | hussainweb |
Comments
Comment #1
hussainwebI don't expect this to pass, but since it is just the exe file, I think we could commit it straight away. To be doubly sure, you could get the file directly from github at https://github.com/symfony/Console/raw/master/Resources/bin/hiddeninput.exe and commit it.
The failure at PIFR is explained in it's own issue at #2531798: Handle binary files in patches.
Comment #3
hussainwebSetting it back to Needs Review, hoping tests won't run again.
Comment #4
hussainwebJust an update: After downloading the file from repository, it runs fine both from cygwin and Windows command prompt.
Comment #14
quietone commentedReading comment #4 it appears that this has been fixed in Symfony. And the release notes, https://symfony.com/blog/symfony-2-2-1-released, include fixing a problem with hiddeninput.exe.
Therefor closing as outdated.