Problem/Motivation

Over in #2467759: Refactor drupal_process_attached() so it doesn't depend on drupal_add_http_header() we're trying to refactor away some @deprecated code, specifically _drupal_add_http_header().

Views is the only system within Drupal core which currently uses the legacy system for setting headers.

The headers being set, however, are not actually headers but the response code for the HTTP request.

This means that any view which generates an HTTP response code needs to somehow set this code.

Views must also cache this result somehow.

An objection raised in #2467759: Refactor drupal_process_attached() so it doesn't depend on drupal_add_http_header() is that any solution must cache these responses for both anonymous and logged-in users.

Here in this issue, we must explore whether this is actually the behavior expected of views, and whether that behavior must extend to HTTP response codes.

The first patch offered is a test which shows that views does not actually cache responses in this way.

Proposed resolution

Determine the desired behavior.

Write tests to demonstrate the desired behavior.

Make the tests pass by implementing the desired behavior.

Remaining tasks

Run the test to see if this is still a problem in a currently supported version of Drupal
Decide if it should be deprecated and removed.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#1 2529500_1.patch8.68 KBmile23

Comments

mile23’s picture

mile23
Primary language English
Location Seattle, WA
CreditAttribution: mile23 as a volunteer commented
Status: Active » Needs review
StatusFileSize
new 2529500_1.patch8.68 KB

This patch is the same test as https://www.drupal.org/node/2467759#comment-9905389

It adds views which are cached, and then attempts to view them using a logged-in user.

It will fail because views does not support this kind of caching.

Status: Needs review » Needs work

The last submitted patch, 1: 2529500_1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Issue tags: +VDC
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Interesting, maybe we also miss out entries from #attached as part of the caching.

Status: Needs work » Needs review

Mile23 queued 1: 2529500_1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: 2529500_1.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Version: 9.4.x-dev » 10.1.x-dev
Issue summary: View changes
Issue tags: +Bug Smash Initiative

This was discussed in Slack at the bugsmash group triage meeting yesterday.

The following points were raised.

  • There is test coverage so it should be easy to determine if this is still a bug or not.
  • It was questioned if this plugin was needed at all. lendude doesn't think it is but, of course, that is hard to prove. He read the original issue that committed the plugin and there was push back from the committers at the time, although dww thought it was a cool feature. We could consider deprecating it once #3039240: Create a way to declare a plugin as deprecated is committed.

I am leaving the status at Needs Work for someone to run the tests and see if this is still a problem.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.