When reviewing AlreadyInstalledException during installation when auto-create MySQL database with special characters we noticed that the escapeDatabase function in Drupal\Core\Database\Connection includes a period in the allowed list of characters. The function documentation says that it is "strictly alphanumeric-plus-underscore" so it would make sense to have these match.
Another problem with this is that MySQL doesn't allow periods in the database name.
Remove the period as an allowed character from the preg_match regex.
The included patch needs review.
No changes.
No API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | align-2490110-3.patch | 1.37 KB | mgifford |
| #3 | align-2490110-3.patch | 1.37 KB | mikeburrelljr |
| #2 | db_escape_function_descriptions_update_2490110_2.patch | 1.35 KB | mikeburrelljr |
| #1 | align-2490110-1.patch | 519 bytes | dasginganinja |
Comments
Comment #1
dasginganinjaComment #2
mikeburrelljr commentedRunning MySQL 5.6.23 here, periods in database names are allowed, however it is a really BAD idea to use them, imo.
CREATE DATABASE `crazy.dbname` ;Same goes for the following:
----
With that being said, I don't think we should prevent someone from doing something allowed (however terrible I may think the idea is).
Instead, how about we update the description for these 3 functions. See supplied patch.
Comment #3
mikeburrelljr commentedRe-rolled patch to adhere to the 80 character length limit for comments.
Comment #4
mgiffordRe-uploading patch for the bots.
Comment #13
quietone commentedThe regex to be changed in this issue was done in #2986452: Database reserved keywords need to be quoted as per the ANSI standard. This has become outdated.