Problem/Motivation
Related to point 15 in #75 on #2301317-75: MenuLinkNG part4: Conversion
Was fixed.
Proposed resolution
Add tests for menu links (the default/plugin ones) and custom menu links title translation in different kinds of rendered places (navigation menu and a menu block).
Remaining tasks
- look at current test coverage to understand what might be missing
- add test(s)
| Task | Novice task? | Contributor instructions | Complete? |
|---|---|---|---|
| Create a patch | Instructions | ||
| Update the issue summary noting if allowed during the beta | Instructions | ||
| Add automated tests | Instructions | ||
| Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
No.
API changes
No.
Comments
Comment #1
yesct commentedComment #2
gábor hojtsyComment #3
yesct commentedsince this is a minor task we should make it clear in the summary why this is allowed at this point in the beta. adding instructions for how to do a beta summary evaluation.
Comment #4
gábor hojtsyThere are still big changes in the menu system, see #2407505: [meta] Finalize the menu links (and other user-entered paths) system. Having more test coverage for what multilingual expects would help ensure our features are kept intact. I think this should not be a problem within beta *especially* given the menu changes going on.
Comment #5
develcuy commentedComment #6
gábor hojtsy@develCuy: are you working on this one?
Comment #7
develcuy commentedRemoved tag by mistake.
Comment #8
fran seva commentedI'm going to work in that issue :)
Comment #22
smustgrave commentedThank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Comment #23
smustgrave commentedSince there's been no follow up and was tagged as a minor going to close this one out. If still a valid task please re-open.
Thanks all!