Updated: Comment #N

Problem/Motivation

Previously comment_uri() added the fragment comment-{cid} to the url so that the page jumped straight to the comment.
Comment::urlInfo() doesn't add this fragment, whilst porting Token to Drupal 8 we noticed the regression

Proposed resolution

Add the fragment back in Comment::urlInfo()

Remaining tasks

Review
Make tests pass if applicable

User interface changes

None

API changes

None

CommentFileSizeAuthor
#24 2198041-24.patch2.02 KBprem suthar
#23 2198041-nr-bot.txt1.46 KBneeds-review-queue-bot
#22 2198041-22.patch2.23 KBkarishmaamin
#20 2198041-nr-bot.txt169 bytesneeds-review-queue-bot
#8 drupal-2198041-8-comment-canonical-url-fragment.patch1.75 KBsweetchuck
#1 2198041-1-Fragment.patch801 bytesgrom358

Comments

grom358’s picture

grom358 commented
Status: Active » Needs review
StatusFileSize
new 2198041-1-Fragment.patch801 bytes

Here is patch to add fragment

Status: Needs review » Needs work

The last submitted patch, 1: 2198041-1-Fragment.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented

There's related issue #2113323: Rename Comment::permalink() to not be ambiguous with ::uri() & #2010202: Deprecate comment_uri()

Seems the canonical URL of comment should always have fragment, and the same time we need to get rid of comment_uri()

+++ b/core/modules/comment/lib/Drupal/comment/Entity/Comment.php
@@ -342,6 +342,15 @@ public static function postDelete(EntityStorageControllerInterface $storage_cont
+  public function urlInfo($rel = 'canonical') {
+    $uri = parent::urlInfo($rel);
+    $uri['options'] = array('fragment' => 'comment-' . $this->id());
+    return $uri;

fragment should be added only for 'canonical', there's other routes in comment entity

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented
Status: Needs work » Needs review
Issue tags: +Drupalaton 2017
StatusFileSize
new drupal-2198041-8-comment-canonical-url-fragment.patch1.75 KB

Status: Needs review » Needs work

The last submitted patch, 8: drupal-2198041-8-comment-canonical-url-fragment.patch, failed testing. View results

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented
Status: Needs work » Needs review

The problem is that the #comment-{cid} is always added to the link options when the $rel is "canonical"
and this breaks the HAL tests.
The expected URL is
../comment/1?_format=hal_json
and the current one is
.../comment/1?_format=hal_json#comment-1

I can re-write the HAL test to except the new URL format, but I don't think this is the right solution. And it may causes side effects, such as break the caching.

How can I decide that when to add the "fragment" and when not to?
I change the issue status to "Needs review" because I need help.

Is it a good approach to check that the "_format" key is not exists in the queryString or exists but not equal to "html"?

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 8.6.x-dev » 8.9.x-dev

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2198041-nr-bot.txt169 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Needs reroll, +Bug Smash Initiative
karishmaamin’s picture

karishmaamin commented
Status: Needs work » Needs review
StatusFileSize
new 2198041-22.patch2.23 KB

Re-rolled #8 patch against 10.1.x. Please review

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2198041-nr-bot.txt1.46 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

prem suthar’s picture

prem suthar commented
StatusFileSize
new 2198041-24.patch2.02 KB

Try To Fix the #22 Custom Cmd Failed Patch.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.