Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
While showing this feature of being able to add/remove languages to a Drupal newbie, she said: "But I only want to disable the language. I don't want to delete it".
Since languages are added through the "+ Add language" button, it would make more sense if the action was "remove" or perhaps better "disable".
Drupal 7, but it is the same in Drupal 9.3.x.
Steps to reproduce
Proposed resolution
Decide if this change should be made and if so, what name of the actions, "remove" or "disable" or something else.
Remaining tasks
postponed on #2851029: [PP-1] Disallow removing a language when there is content in that language See #25 for details.
Ask in #usability for direction
User interface changes
admin/config/regional/language.
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #22 | 1870454-22.patch | 7.89 KB | yogeshmpawar |
| #6 | lang_delete_to_remove_1870454-05.patch | 11.43 KB | klonos |
| #3 | lang_delete_to_disable_1870454-03.patch | 12.47 KB | donutdan4114 |
| #1 | lang_delete_to_disable_1870454-01.patch | 1.93 KB | donutdan4114 |
| disable_action_language_instead_of_delete.png | 51.11 KB | klonos |
Comments
Comment #1
donutdan4114 commentedI agree, delete does not make sense there.
Comment #3
donutdan4114 commentedModified the test files to match the new text.
Comment #4
donutdan4114 commentedComment #5
klonosWow! Thanx for you very prompt reaction Daniel ;)
I thought that this would be a 1 or 2-liner thing. but there were so many mentions of language "deletion". Thanx again.
Comment #6
klonos...I applied the patch and showed things again to the same person. This time she was puzzled that "disable" actually removed the language from the list and that she had to re-add it. I think she's right and that the way things are now languages are actually removed.
So here's another patch. It's almost identical to the one in #3, but I manually replaced the words "disable"/"disabled" with "remove"/"removed" instead (where appropriate - in some places it simply did not make sense or the word "remove" was already used before patch). So, once we review either of these patches, we only need to decide if "remove" or "disable" is more appropriate and commit the respective patch.
PS: I take no credit for the patch - all props and thanx go to Daniel.
Comment #8
donutdan4114 commentedYea it was more complicated than it seemed.
Comment #9
klonosYeah, serves me right for trying to manually edit a patch instead of creating a new one ;)
Comment #18
quietone commentedUpdated the IS, tagging for a usability review to decide on a course of action.
The screen shot is from Drupal 7 but it is effectively the same for Drupal 8 so I have chosen to not update it.
Comment #19
aaronmchaleQueued for usability review at #3227759: Drupal Usability Meeting 2021-08-13 or a future meeting.
Comment #20
vikashsoni commented@klonos @donutdan4114 patch needs to re-roll because not working in drupal 9.3.x-dev
Comment #21
yogeshmpawarWorking on re-roll.
Comment #22
yogeshmpawarAdded updated patch which works with latest drupal 9.3.x branch.
Comment #24
quietone commented@vikashsoni, @yogeshmpawar, before suggesting a reroll or taking the time to reroll a patch it is good practice to read the entire issue to make sure that is the next step. See comment #18 and also the Issue Summary itself where it states that there has not been a decision on what to do here, if anything. The next step here is a Usability review. Only after that has happened will it be known if a patch is needed or not.
Comment #25
aaronmchaleHi all
Sorry we did actually review this at #3227759: Drupal Usability Meeting 2021-08-13, however we clearly did not get round to posting a comment. Thank you to @quietone for noting that the review comment was still to be done.
When we tried to review this issue on a live site, we quite quickly ran into this bug #2851029: [PP-1] Disallow removing a language when there is content in that language, and so we agreed that until that issue is resolved we were unable to provide a solid recommendation for this issue.
Therefor I am postponing this issue on #2851029: [PP-1] Disallow removing a language when there is content in that language.
I would refer to comment #56 (#2851029-56: [PP-1] Disallow removing a language when there is content in that language) on that issue, which is a brief summary of the steps we went through to reproduce that issue.
As a side note, we all ran into the issue #2582535: Duplicated rows on admin/content if author is translated during our review. We are not also postponing this issue on that issue, but I thought it was worth highlighting.
As a final note, we identified that there is clearly a group of related issues here, perhaps they need to be organised into some kind of meta issue to try and improve the experience that users get when dealing with removing translations. One idea that was proposed during the discussion was to replicate the experience that users get when cancelling/deleting a user; When doing that, users are presented with a screen which gives them various options on how to proceed; We felt that this could be a good way forward as a long-term solution to imrpoving the experience here.
Comment #28
quietone commentedAdding what this is postponed on to the remaining tasks per Remining tasks.